Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use isinstance in internal comparison for splitter, create a splitter example #924

Closed
mfeurer opened this issue Aug 13, 2020 · 2 comments
Closed
Labels
documentation Something to be documented

Comments

@mfeurer
Copy link
Contributor

mfeurer commented Aug 13, 2020

See this on how the comparison is done based on the classname: https://github.com/automl/auto-sklearn/blob/master/autosklearn/evaluation/train_evaluator.py#L913

Instead, we should use isinstance

@mfeurer
Copy link
Contributor Author

mfeurer commented Aug 14, 2020

This would also solve #498 when using sklearn's PredefinedSplitter.

@franchuterivera franchuterivera added the documentation Something to be documented label Feb 17, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs for the next 7 days. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something to be documented
Projects
None yet
Development

No branches or pull requests

2 participants