Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump coverlet to 3.0.1 #1247

Merged
merged 1 commit into from
Jan 23, 2021
Merged

fix: bump coverlet to 3.0.1 #1247

merged 1 commit into from
Jan 23, 2021

Conversation

alsami
Copy link
Member

@alsami alsami commented Jan 23, 2021

This problem was actually fixed with 3.0.1, not with 3.0.0.

@alsami alsami changed the title fix: bump coverlet to 3.0.1 so determenistic builds do not cause prob… fix: bump coverlet to 3.0.1 Jan 23, 2021
@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #1247 (3ec9306) into develop (9bddb7b) will increase coverage by 14.87%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #1247       +/-   ##
============================================
+ Coverage    61.21%   76.08%   +14.87%     
============================================
  Files          185      185               
  Lines         4821     4821               
  Branches       994      994               
============================================
+ Hits          2951     3668      +717     
+ Misses        1396      679      -717     
  Partials       474      474               
Impacted Files Coverage Δ
...Autofac/RegistrationExtensions.AssemblyScanning.cs 46.87% <0.00%> (+1.56%) ⬆️
...e/Registration/DefaultRegisteredServicesTracker.cs 83.72% <0.00%> (+3.10%) ⬆️
src/Autofac/Core/Lifetime/LifetimeScope.cs 81.11% <0.00%> (+4.19%) ⬆️
...ing/Middleware/ActivatorErrorHandlingMiddleware.cs 91.30% <0.00%> (+4.34%) ⬆️
src/Autofac/ModuleRegistrationExtensions.cs 44.44% <0.00%> (+4.44%) ⬆️
src/Autofac/Core/ResolvedParameter.cs 54.54% <0.00%> (+4.54%) ⬆️
src/Autofac/TypeExtensions.cs 41.86% <0.00%> (+4.65%) ⬆️
src/Autofac/Core/Resolving/ResolveOperation.cs 84.61% <0.00%> (+5.49%) ⬆️
...fac/Core/Activators/Reflection/BoundConstructor.cs 80.00% <0.00%> (+5.71%) ⬆️
...tofac/Core/Registration/ServiceRegistrationInfo.cs 78.37% <0.00%> (+7.20%) ⬆️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bddb7b...a4f800c. Read the comment docs.

@alsami alsami marked this pull request as ready for review January 23, 2021 14:56
@alsami
Copy link
Member Author

alsami commented Jan 23, 2021

@alistairjevans I love raising the code-coverage by 15% w/ zero code changes.

Good to go I think!

Copy link
Member

@alistairjevans alistairjevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah! 🚀

@alistairjevans alistairjevans merged commit 9a2d3a4 into autofac:develop Jan 23, 2021
@alsami
Copy link
Member Author

alsami commented Jun 21, 2021

#1241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants