Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to stable coverlet 3.x packages #1241

Closed
alsami opened this issue Dec 12, 2020 · 4 comments
Closed

Upgrade to stable coverlet 3.x packages #1241

alsami opened this issue Dec 12, 2020 · 4 comments
Assignees

Comments

@alsami
Copy link
Member

alsami commented Dec 12, 2020

Because of the fix required for the coverage to be collected correctly in #1240, we have added pre-releases of coverlet.collector and coverlet.msbuild. They may be updated to the stable version once they are released on nuget.org.

The additional nightly-nuget feed from coverlet may also be removed then from the NuGet.config.

@alsami
Copy link
Member Author

alsami commented Jun 18, 2021

Closing this since it has been merged in January already :)

@alsami alsami closed this as completed Jun 18, 2021
@alistairjevans
Copy link
Member

@alsami, didn't we leave the issue open because we saw a big drop in the coverage numbers after merge?

I seem to recall we discussed it in the PR after it was merged?

@alsami
Copy link
Member Author

alsami commented Jun 18, 2021

@alsami, didn't we leave the issue open because we saw a big drop in the coverage numbers after merge?

I seem to recall we discussed it in the PR after it was merged?

Just double checked. The PR caused a huge drop but it was fixed with a package update that we already got. Currently we are at 77 percent. Almost around the number we had also during the time before the PR.

@alistairjevans
Copy link
Member

Ok, great, thanks. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants