Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update coverlage packages to stable 3.0.0 version #1244

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

alsami
Copy link
Member

@alsami alsami commented Jan 12, 2021

As per #1241, updating coverlet* to stable 3.0.0 release.

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #1244 (d8267bf) into develop (0afd90f) will decrease coverage by 14.93%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #1244       +/-   ##
============================================
- Coverage    76.14%   61.21%   -14.94%     
============================================
  Files          185      185               
  Lines         4821     4821               
  Branches       994      994               
============================================
- Hits          3671     2951      -720     
- Misses         676     1396      +720     
  Partials       474      474               
Impacted Files Coverage Δ
src/Autofac/Core/SelfComponentRegistration.cs 10.00% <0.00%> (-80.00%) ⬇️
...Autofac/Builder/ConcreteReflectionActivatorData.cs 25.00% <0.00%> (-75.00%) ⬇️
src/Autofac/Builder/RegistrationBuilder.cs 23.61% <0.00%> (-59.73%) ⬇️
...actories/GeneratedFactoryRegistrationExtensions.cs 42.85% <0.00%> (-57.15%) ⬇️
...htAdapters/LightweightAdapterRegistrationSource.cs 23.21% <0.00%> (-55.36%) ⬇️
...ac/Features/GeneratedFactories/FactoryGenerator.cs 37.89% <0.00%> (-54.74%) ⬇️
...utofac/Core/Resolving/Pipeline/ServicePipelines.cs 46.66% <0.00%> (-53.34%) ⬇️
src/Autofac/Core/Resolving/ActivatorExtensions.cs 25.00% <0.00%> (-50.00%) ⬇️
...tedFactories/GeneratedFactoryRegistrationSource.cs 30.43% <0.00%> (-47.83%) ⬇️
...eatures/AttributeFilters/RegistrationExtensions.cs 30.76% <0.00%> (-46.16%) ⬇️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0afd90f...aff5821. Read the comment docs.

@alsami alsami closed this Jan 12, 2021
@alsami alsami reopened this Jan 12, 2021
Copy link
Member

@tillig tillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@tillig tillig merged commit 9bddb7b into autofac:develop Jan 12, 2021
@alistairjevans
Copy link
Member

Thanks for staying on top of this @alsami!

@alistairjevans
Copy link
Member

I actually just noticed that our coverage dropped by 14% according to that latest coverage report. Any idea what's up with that? Is it due to the new version?

@alsami
Copy link
Member Author

alsami commented Jan 12, 2021

Yes, I noticed that too, damn, should have marked it as WIP. Will find a solution soon.

@alistairjevans
Copy link
Member

Just linking #1246 for cross-referencing coverage issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants