Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HasChange check to action secrets and dependencies #903

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

This PR adds the data.HasChange check for action secrets and dependencies, so they don't always get sent to the API if no changes were needed.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner December 19, 2023 15:58
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b04210) 89.96% compared to head (f24a354) 90.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #903      +/-   ##
==========================================
+ Coverage   89.96%   90.00%   +0.04%     
==========================================
  Files         101      101              
  Lines       13779    13779              
==========================================
+ Hits        12396    12402       +6     
+ Misses        980      976       -4     
+ Partials      403      401       -2     
Files Coverage Δ
internal/auth0/action/expand.go 94.23% <100.00%> (+5.76%) ⬆️
internal/auth0/action/resource.go 87.30% <100.00%> (ø)

@willvedd
Copy link
Contributor

If you regenerate the recordings for the related tests, do they omit the secrets field from the payload? That would be adequate in lieu of a test IMO.

Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the question about the recordings. If we add this functionality, we should revert or edit the documentation changes I made in #898 .

@sergiught
Copy link
Contributor Author

@willvedd done and done ✅

@sergiught sergiught requested a review from willvedd December 20, 2023 09:23
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💪

@sergiught sergiught merged commit c2807a3 into main Dec 20, 2023
6 checks passed
@sergiught sergiught deleted the actions-deps-secrets branch December 20, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants