-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HasChange check to action secrets and dependencies #903
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #903 +/- ##
==========================================
+ Coverage 89.96% 90.00% +0.04%
==========================================
Files 101 101
Lines 13779 13779
==========================================
+ Hits 12396 12402 +6
+ Misses 980 976 -4
+ Partials 403 401 -2
|
If you regenerate the recordings for the related tests, do they omit the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the question about the recordings. If we add this functionality, we should revert or edit the documentation changes I made in #898 .
@willvedd done and done ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 💪
🔧 Changes
This PR adds the data.HasChange check for action secrets and dependencies, so they don't always get sent to the API if no changes were needed.
📚 References
🔬 Testing
📝 Checklist