Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting limitation of managing action secrets out-of-bound #898

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Dec 13, 2023

🔧 Changes

As noted in #860, users are having issues managing their action secrets out-of-band through the ignore_changes block. However, this doesn't result in the expected behavior and secrets can still be deleted in the process. This PR updates the documentation very clear that secrets and dependencies cannot be managed out-of-band. In short, this is because the provider cannot discern between intentionally empty set of secrets and ignoring secrets by omission.

📚 References

Related Github Issue: #860 (comment)

🔬 Testing

N/A.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner December 13, 2023 20:28
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.03%. Comparing base (d50bfd3) to head (dca0907).
Report is 83 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #898   +/-   ##
=======================================
  Coverage   90.03%   90.03%           
=======================================
  Files         101      101           
  Lines       13779    13779           
=======================================
  Hits        12406    12406           
  Misses        973      973           
  Partials      400      400           
Files with missing lines Coverage Δ
internal/auth0/action/resource.go 87.30% <100.00%> (ø)

@sergiught sergiught merged commit 9b04210 into main Dec 19, 2023
6 checks passed
@sergiught sergiught deleted the ESD-33213-empyt-actions-secrets-docs branch December 19, 2023 14:26
sergiught added a commit that referenced this pull request Dec 20, 2023
sergiught added a commit that referenced this pull request Dec 20, 2023
* Add HasChange check to action secrets and dependencies

* Revert "Documenting limitation of managing action secrets out-of-bound (#898)"

This reverts commit 9b04210.

* Update recordings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants