Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing GA version of node 18 actions runtime #709

Merged
merged 8 commits into from
Jul 12, 2023
25 changes: 25 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,28 @@
## 0.50.0

FEATURES:

- `auth0_pages`: Add new resource to manage Auth0 pages (`change_password`, `error`, `guardian_mfa`, `login`) ([#691](https://github.com/auth0/terraform-provider-auth0/pull/691))

ENHANCEMENTS:

- `resource/auth0_client`: Add `post_login_prompt` to available options for the `organization_require_behavior` attribute ([#680](https://github.com/auth0/terraform-provider-auth0/pull/680))
- `resource/auth0_connection`: Relax `metadata` validation by not requiring key length to be between 0 and 10 characters ([#685](https://github.com/auth0/terraform-provider-auth0/pull/685))

BUG FIXES:

- `resource/auth0_organization_connections`, `resource/auth0_organization_members`: Address a bug causing inconsistencies in the safeguarding process, ensuring reliable protection against erasing unintended modifications ([#645](https://github.com/auth0/terraform-provider-auth0/pull/645))
- `resource/auth0_organization_members`: Address a bug that prevented the creation of organization members when the member list was empty ([#646](https://github.com/auth0/terraform-provider-auth0/pull/646))
- `resource/auth0_connection`, `resource/auth0_organization_member`,`resource/auth0_user`: Update diffing algorithm to address a bug where the order of additions and removals was causing incorrect results ([#650](https://github.com/auth0/terraform-provider-auth0/pull/650))
- `resource/auth0_connection`: Remove invalid connection strategies ([#694](https://github.com/auth0/terraform-provider-auth0/pull/694))
- `resource/auth0_client`: Modify the behavior to only allow the update of the `is_token_endpoint_ip_header_trusted` setting after the client has been created successfully ([#696](https://github.com/auth0/terraform-provider-auth0/pull/696))
- `resource/auth0_branding`: Addressed a bug that prevented the deletion of the template when the universal login block was removed ([#695](https://github.com/auth0/terraform-provider-auth0/pull/695))

NOTES:

- :warning: Check our [migration guide](https://github.com/auth0/terraform-provider-auth0/blob/main/MIGRATION_GUIDE.md) to navigate the deprecations that were added in this release.


## 0.49.0

FEATURES:
Expand Down
2 changes: 1 addition & 1 deletion docs/resources/action.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ resource "auth0_action" "my_action" {

- `dependencies` (Block Set) List of third party npm modules, and their versions, that this action depends on. (see [below for nested schema](#nestedblock--dependencies))
- `deploy` (Boolean) Deploying an action will create a new immutable version of the action. If the action is currently bound to a trigger, then the system will begin executing the newly deployed version of the action immediately.
- `runtime` (String) The Node runtime. Defaults to `node12`. Possible values are: `node12`, `node16` or `node18`.
- `runtime` (String) The Node runtime. Defaults to `node12`. Possible values are: `node12`, `node16` or `node18-actions`.
- `secrets` (Block List) List of secrets that are included in an action or a version of an action. (see [below for nested schema](#nestedblock--secrets))

### Read-Only
Expand Down
5 changes: 3 additions & 2 deletions internal/auth0/action/resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,11 @@ func NewResource() *schema.Resource {
ValidateFunc: validation.StringInSlice([]string{
"node12",
"node16",
"node18",
"node18", // Node 18 beta.
"node18-actions", // Node 18 GA.
}, false),
Description: "The Node runtime. Defaults to `node12`. Possible values are: " +
"`node12`, `node16` or `node18`.",
"`node12`, `node16` or `node18-actions`.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While node18 is technically a valid value, it will be removed at a future date and we should encourage our users to leverage the GA version.

},
"secrets": {
Type: schema.TypeList,
Expand Down
2 changes: 1 addition & 1 deletion internal/auth0/action/resource_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ func TestAccAction(t *testing.T) {
const testAccActionConfigCreateWithFailedBuild = `
resource auth0_action my_action {
name = "Test Action {{.testName}}"
runtime = "node18"
runtime = "node18-actions"
deploy = true
code = <<-EOT
exports.onContinuePostLogin = async (event, api) => {
Expand Down
Loading