Allowing GA version of node 18 actions runtime #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e600c0e.
willvedd
commented
Jul 12, 2023
| }, false), | ||
| Description: "The Node runtime. Defaults to `node12`. Possible values are: " + | ||
| "`node12`, `node16` or `node18`.", | ||
| "`node12`, `node16` or `node18-actions`.", |
There was a problem hiding this comment.
While node18 is technically a valid value, it will be removed at a future date and we should encourage our users to leverage the GA version.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v1 #709 +/- ##
=======================================
Coverage 87.60% 87.60%
=======================================
Files 84 84
Lines 13573 13574 +1
=======================================
+ Hits 11890 11891 +1
Misses 1272 1272
Partials 411 411
|
sergiught
approved these changes
Jul 12, 2023
|
this problem still occurs in TerraformProvider 1.1.2 - can you please give an update how to use node18-actions as value with terraform ? Thx, Markus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
As reported by #705 , a new
node18-actionsvalue exists specifically for Node 18 GA whereas the previousnode18value is designated for beta. This PR adds that value to the validation list but also de-emphasizes the usage of the beta version to encourage users to leverage the GA version by default.📚 References
Related Issue: #705
🔬 Testing
Changing acceptance test to use new value, confirming its usage.
📝 Checklist