DXCDT-471: Fix creating org members when member list is empty #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
=======================================
Coverage 86.60% 86.60%
=======================================
Files 80 80
Lines 12168 12168
=======================================
Hits 10538 10538
Misses 1243 1243
Partials 387 387 |
sergiught
force-pushed
the
patch/DXCDT-473-fix-guard
branch
2 times, most recently
from
72a013e to
3388f02
Compare
sergiught
force-pushed
the
patch/DXCDT-471-fix-members
branch
from
7688568 to
e8bf000
Compare
willvedd
reviewed
Jun 20, 2023
sergiught
force-pushed
the
patch/DXCDT-473-fix-guard
branch
from
3388f02 to
edff628
Compare
sergiught
force-pushed
the
patch/DXCDT-471-fix-members
branch
from
e8bf000 to
c5232c5
Compare
willvedd
approved these changes
Jun 20, 2023
Widcket
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
While ensuring we can reliably run our tests e2e on a real test tenant, we encountered a bug where the organization members resource triggered an error when trying to create the resource with an empty members list. This PR fixes this issue by skipping the API call if the list is empty.
📚 References
🔬 Testing
📝 Checklist