Fix creating org members when member list is empty

auth0 · Jun 20, 2023 · e8bf000 · e8bf000
1 parent 3388f02
commit e8bf000
Show file tree

Hide file tree

Showing 3 changed files with 1,843 additions and 796 deletions.
diff --git a/internal/auth0/organization/resource_members.go b/internal/auth0/organization/resource_members.go
@@ -72,7 +72,7 @@ func createOrganizationMembers(ctx context.Context, data *schema.ResourceData, m
 		return diagnostics
 	}
 
-	if len(membersToAdd) > len(alreadyMembers.Members) {
+	if len(membersToAdd) > 0 && len(membersToAdd) > len(alreadyMembers.Members) {
 		if err := api.Organization.AddMembers(organizationID, membersToAdd); err != nil {
 			return diag.FromErr(err)
 		}

diff --git a/internal/auth0/organization/resource_members_test.go b/internal/auth0/organization/resource_members_test.go
@@ -159,6 +159,9 @@ func TestAccOrganizationMembers(t *testing.T) {
 				Config:      acctest.ParseTestName(testAccOrganizationMembersPreventErasingMembersOnCreate, testName),
 				ExpectError: regexp.MustCompile("Organization with non empty members"),
 			},
+			{
+				Config: acctest.ParseTestName(testAccOrganizationMembersRemoveAllMembers, testName),
+			},
 			{
 				Config: acctest.ParseTestName(testAccOrganizationMembersWithOneMember, testName),
 				Check: resource.ComposeTestCheckFunc(