Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to obtain the custom domain id needed for importing an auth0_custom_domain resource. #463

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

ginman86
Copy link
Contributor

@ginman86 ginman86 commented Feb 1, 2023

🔧 Changes

Document how to obtain the custom domain id needed for importing an auth0_custom_domain resource.

@ginman86 ginman86 requested a review from a team as a code owner February 1, 2023 23:52
@codecov-commenter
Copy link

Codecov Report

Base: 87.47% // Head: 87.47% // No change to project coverage 👍

Coverage data is based on head (0bb3e1a) compared to base (01d9b9e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #463   +/-   ##
=======================================
  Coverage   87.47%   87.47%           
=======================================
  Files          42       42           
  Lines        9289     9289           
=======================================
  Hits         8126     8126           
  Misses        884      884           
  Partials      279      279           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -52,6 +52,9 @@ Import is supported using the following syntax:
```shell
# Custom domains can be imported using their ID.
#
# You can find existing custom domain IDs using the auth0 management api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in #462 (comment) applies here as well:)

The docs folder is automatically generated. The import example script that needs to be changed is here: https://github.com/auth0/terraform-provider-auth0/blob/patch/contributing/examples/resources/auth0_custom_domain/import.sh and then run make docs.

Document how to obtain the custom domain id needed for importing an auth0_custom_domain resource.
Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @ginman86 👋🏻 I rebased and made the ammendments.

@sergiught sergiught merged commit 7c50f16 into auth0:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants