-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the type
values for the auth0 log stream resource
#462
Conversation
docs/resources/log_stream.md
Outdated
@@ -60,7 +60,7 @@ resource "auth0_log_stream" "example_aws" { | |||
|
|||
- `name` (String) Name of the log stream. | |||
- `sink` (Block List, Min: 1, Max: 1) The sink configuration for the log stream. (see [below for nested schema](#nestedblock--sink)) | |||
- `type` (String) Type of the log stream, which indicates the sink provider. | |||
- `type` (String) Type of the log stream, which indicates the sink provider. Possible values are: `eventbridge`, `eventgrid`, `http`, `datadog`, `splunk`, `sumo`, `mixpanel`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i pulled these from the provider's validation response: Error: expected type to be one of [eventbridge eventgrid http datadog splunk sumo mixpanel], got
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ginman86 👋🏻
Thanks for the contribution! This is definitely a good addition!
Would you mind updating the description for this here
Description: "Type of the log stream, which indicates the sink provider.", |
make docs
? As the content within the docs folder is completely generated and shouldn't be modified manually. Additionally, we also included support for segment
log stream.
To give better guiding on how to contribute we updated as well our CONTRIBUTING.md docs: https://github.com/auth0/terraform-provider-auth0/blob/patch/contributing/CONTRIBUTING.md#documentation (pending to be merged in).
Codecov ReportBase: 87.47% // Head: 87.47% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
=======================================
Coverage 87.47% 87.47%
=======================================
Files 42 42
Lines 9289 9289
=======================================
Hits 8126 8126
Misses 884 884
Partials 279 279 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
docs/resources/log_stream.md
Outdated
@@ -60,7 +60,7 @@ resource "auth0_log_stream" "example_aws" { | |||
|
|||
- `name` (String) Name of the log stream. | |||
- `sink` (Block List, Min: 1, Max: 1) The sink configuration for the log stream. (see [below for nested schema](#nestedblock--sink)) | |||
- `type` (String) Type of the log stream, which indicates the sink provider. | |||
- `type` (String) Type of the log stream, which indicates the sink provider. Possible values are: `eventbridge`, `eventgrid`, `http`, `datadog`, `splunk`, `sumo`, `mixpanel`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ginman86 👋🏻
Thanks for the contribution! This is definitely a good addition!
Would you mind updating the description for this here
Description: "Type of the log stream, which indicates the sink provider.", |
make docs
? As the content within the docs folder is completely generated and shouldn't be modified manually. Additionally, we also included support for segment
log stream.
To give better guiding on how to contribute we updated as well our CONTRIBUTING.md docs: https://github.com/auth0/terraform-provider-auth0/blob/patch/contributing/CONTRIBUTING.md#documentation (pending to be merged in).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ginman86 👋🏻 Thanks for the contribution! I had some time to rebase this and add the ammendments.
type
values for the auth0 log stream resource.type
values for the auth0 log stream resource
🔧 Changes
Document the possible
type
values for the auth0 log stream resource.