Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update messages in Forms using terraform. #1088

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

kushalshit27
Copy link
Contributor

🔧 Changes

Fix: update messages in Forms using terraform.

resource "auth0_form" "my_form" {
 # other properties 
  messages {
    errors = jsonencode({
      ERR_REQUIRED_PROPERTY = "This field is required for user kyc."
    })
  }
}

📚 References

https://registry.terraform.io/providers/auth0/auth0/latest/docs/resources/form

🔬 Testing

tested create and update for messages in Forms using terraform.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@kushalshit27 kushalshit27 self-assigned this Nov 27, 2024
@kushalshit27 kushalshit27 marked this pull request as ready for review November 27, 2024 15:23
@kushalshit27 kushalshit27 requested a review from a team as a code owner November 27, 2024 15:23
@kushalshit27 kushalshit27 merged commit 720d7a0 into main Nov 27, 2024
5 checks passed
@kushalshit27 kushalshit27 deleted the fix/DXCDT-745-update-messages-in-forms branch November 27, 2024 15:25
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.37%. Comparing base (e158550) to head (9b5bd4d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/auth0/form/expand.go 62.50% 1 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1088   +/-   ##
=======================================
  Coverage   89.37%   89.37%           
=======================================
  Files         128      128           
  Lines       17735    17737    +2     
=======================================
+ Hits        15851    15853    +2     
+ Misses       1333     1331    -2     
- Partials      551      553    +2     
Files with missing lines Coverage Δ
internal/auth0/form/expand.go 53.17% <62.50%> (+0.75%) ⬆️

developerkunal pushed a commit to bryanroute/terraform-provider-auth0 that referenced this pull request Nov 28, 2024
fix: update error messages in Forms using terraform.

Co-authored-by: Rajat Bajaj <[email protected]>
developerkunal added a commit that referenced this pull request Nov 28, 2024
* Added support to set the oidc backchannel initiators mode and selected initiators

* Regenerated docs to add new properties

* Changed to use oidc_logout block

* Fixed And Added Test Cases

* Updated Docs

* Updated TestAccDataClients to avoid noisy plan (#1087)

Updated the test to avoid noisy plan

* fix: update messages in Forms using terraform. (#1088)

fix: update error messages in Forms using terraform.

Co-authored-by: Rajat Bajaj <[email protected]>

---------

Co-authored-by: Kunal Dawar <[email protected]>
Co-authored-by: Rajat Bajaj <[email protected]>
Co-authored-by: Kushal <[email protected]>
Co-authored-by: KunalOfficial <[email protected]>
duedares-rvj added a commit that referenced this pull request Nov 28, 2024
* Added support to set the oidc backchannel initiators mode and selected initiators

* Regenerated docs to add new properties

* Changed to use oidc_logout block

* Fixed And Added Test Cases

* Updated Docs

* Updated TestAccDataClients to avoid noisy plan (#1087)

Updated the test to avoid noisy plan

* fix: update messages in Forms using terraform. (#1088)

fix: update error messages in Forms using terraform.

Co-authored-by: Rajat Bajaj <[email protected]>

---------

Co-authored-by: Kunal Dawar <[email protected]>
Co-authored-by: Rajat Bajaj <[email protected]>
Co-authored-by: Kushal <[email protected]>
Co-authored-by: KunalOfficial <[email protected]>
Signed-off-by: Rajat Bajaj <[email protected]>
This was referenced Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants