Updated TestAccDataClients to avoid noisy plan #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1087 +/- ##
=======================================
Coverage 89.37% 89.37%
=======================================
Files 128 128
Lines 17735 17735
=======================================
Hits 15851 15851
Misses 1333 1333
Partials 551 551 |
acwest
approved these changes
Nov 27, 2024
developerkunal
pushed a commit
to bryanroute/terraform-provider-auth0
that referenced
this pull request
Nov 28, 2024
Updated the test to avoid noisy plan
developerkunal
added a commit
that referenced
this pull request
Nov 28, 2024
* Added support to set the oidc backchannel initiators mode and selected initiators * Regenerated docs to add new properties * Changed to use oidc_logout block * Fixed And Added Test Cases * Updated Docs * Updated TestAccDataClients to avoid noisy plan (#1087) Updated the test to avoid noisy plan * fix: update messages in Forms using terraform. (#1088) fix: update error messages in Forms using terraform. Co-authored-by: Rajat Bajaj <[email protected]> --------- Co-authored-by: Kunal Dawar <[email protected]> Co-authored-by: Rajat Bajaj <[email protected]> Co-authored-by: Kushal <[email protected]> Co-authored-by: KunalOfficial <[email protected]>
duedares-rvj
added a commit
that referenced
this pull request
Nov 28, 2024
* Added support to set the oidc backchannel initiators mode and selected initiators * Regenerated docs to add new properties * Changed to use oidc_logout block * Fixed And Added Test Cases * Updated Docs * Updated TestAccDataClients to avoid noisy plan (#1087) Updated the test to avoid noisy plan * fix: update messages in Forms using terraform. (#1088) fix: update error messages in Forms using terraform. Co-authored-by: Rajat Bajaj <[email protected]> --------- Co-authored-by: Kunal Dawar <[email protected]> Co-authored-by: Rajat Bajaj <[email protected]> Co-authored-by: Kushal <[email protected]> Co-authored-by: KunalOfficial <[email protected]> Signed-off-by: Rajat Bajaj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation didn't take the order of returns clients into consideration which can change over multiple runs.
Thus, the index 0 and index 1 could be swapped.
Updated the implementation such that the index doesn't matter while the flattening logic is tested correctly.
🔧 Changes
📚 References
🔬 Testing
📝 Checklist