Migrate to ES6

[vikaspotluri123]

• Remove usage of object.assign (dep)
• Remove usage of util._extend (prefer native Object.assign)
• Require Node v6+
• var -> const / let
• Object destructuring
• Native ES6 Classes
• Template strings

Refs #303

Todo

• Fix tests
• Migrate management folder

[vikaspotluri123]

Not sure why this file is so different, maybe precommit hook?

[luisrudge]

Yeah. Not sure why it wasn't formatted before..

[vikaspotluri123]

https://github.com/vikaspotluri123/node-auth0/blob/es6/src/auth/index.js#L448 - I didn't migrate this to let / const since it's an unused variable - didn't want to forget to mention this - Should I remove it, or is the function call incorrect? There's another version of this on line 405

[luisrudge]

If it's unused, feel free to remove it. Probably some copy/pasting mistake

[vikaspotluri123]

  changePassword(data, cb) {
    var translatedData = {
      connection: data.connection,
      email: data.email || data.username,
      password: data.password
    };

    return this.database.changePassword(data, cb);
  }

Based on other functions, it feels like the function call should use translatedData, not data

[vikaspotluri123]

I didn't want to fix the typo in https://github.com/vikaspotluri123/node-auth0/blob/es6/src/management/index.js#L1137 since it's part of the code rather than docs - thoughts?

[luisrudge]

Let's not change behaviors in this PR. If the variable is unused, leave it as is

[luisrudge]

Can't remove/fix that typo because it's part of the public API. It's already deprecated and it will be removed in the next major

[luisrudge]

Although... This PR will be a breaking change anyway... 🤔 Let me think about this.

[vikaspotluri123]

@luisrudge you're not waiting on me for anything, right? Just wanted to make sure 😄

[luisrudge]

@vikasjayaram I didn't know it was done 😬 I'll try to do some testing this week. I still need to discuss with the team if this should be considered a breaking change or not (I think it is).

[luisrudge]

hey @vikasjayaram - I'm sorry this is take more than expected. I'm not sure when this will get merged but I want to make it clear that I already contacted our hacktoberfest admin to make sure you get points for this one 🎉 Thanks so much for this PR.

[vikaspotluri123]

No worries, thanks for the update 😄

[luisrudge]

@vikaspotluri123 sorry I missed your username twice 😬

[luisrudge]

Thanks @vikasjayaram for all your effort in this issue. We have big plans for Management SDKs and, sadly, we'll have to drop this PR in favor of what's next.