-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update bluebird #307
Comments
#304 actually removes bluebird 😬 Just out of curiosity, what bundle are you mentioning? Are you installing this in docker or something? |
ah that's quite cool. I was briefly checking the code and noticed that bluebird was not really used. (We are deploying into lambda. ) |
Thanks for clarifying 🎉 |
I thought I already replied to this but I can't find the reply 😲 Unfortunately, node v6 doesn't have native promisify support, so there's still a dependency on bluebird for it. We can probably clone the core code (located in https://github.com/nodejs/node/blob/master/lib/internal/util.js) and get rid of it in May after V6 is dropped, or use a polyfill |
https://node.green/#ES2015-built-ins-Promise This table says it does though.. |
|
I meant It's used in the memoizer |
duhhhhh. Sorry. I misread your comment. I think it's better to use https://www.npmjs.com/package/es6-promisify for it. We don't want to "own" something like that. |
Regenerating the lockfile, but done! |
Would be possible to update bluebird in a subsequent release?
I'm using auth0 in an environment with requirement on size of the final bundle and I have two bluebird instances (the one required in auth0) and the latest one required by other packages.
The text was updated successfully, but these errors were encountered: