Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bluebird #307

Closed
alemhnan opened this issue Oct 3, 2018 · 9 comments
Closed

update bluebird #307

alemhnan opened this issue Oct 3, 2018 · 9 comments

Comments

@alemhnan
Copy link

alemhnan commented Oct 3, 2018

Would be possible to update bluebird in a subsequent release?

I'm using auth0 in an environment with requirement on size of the final bundle and I have two bluebird instances (the one required in auth0) and the latest one required by other packages.

@luisrudge
Copy link
Contributor

#304 actually removes bluebird 😬

Just out of curiosity, what bundle are you mentioning? Are you installing this in docker or something?

@alemhnan
Copy link
Author

alemhnan commented Oct 3, 2018

ah that's quite cool. I was briefly checking the code and noticed that bluebird was not really used.

(We are deploying into lambda. )

@luisrudge
Copy link
Contributor

Thanks for clarifying 🎉
Bluebird is being used today because we support old version os nodejs. Next release, we'll drop support for node <6, so we'll have native promises.

@vikaspotluri123
Copy link

I thought I already replied to this but I can't find the reply 😲

Unfortunately, node v6 doesn't have native promisify support, so there's still a dependency on bluebird for it. We can probably clone the core code (located in https://github.com/nodejs/node/blob/master/lib/internal/util.js) and get rid of it in May after V6 is dropped, or use a polyfill

@luisrudge
Copy link
Contributor

https://node.green/#ES2015-built-ins-Promise This table says it does though..

@luisrudge
Copy link
Contributor

➜  ~ node -v
v6.14.4
➜  ~ node
> typeof Promise
'function'

@vikaspotluri123
Copy link

vikaspotluri123 commented Oct 4, 2018

I meant require('util').promisify 😄

It's used in the memoizer

@luisrudge
Copy link
Contributor

duhhhhh. Sorry. I misread your comment. I think it's better to use https://www.npmjs.com/package/es6-promisify for it. We don't want to "own" something like that.

@vikaspotluri123
Copy link

Regenerating the lockfile, but done!

@mattiasnixell mattiasnixell mentioned this issue Jul 28, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants