Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop UMD bundle #193

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Drop UMD bundle #193

merged 2 commits into from
Aug 15, 2023

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Aug 14, 2023

Description

Dropping the UMD bundle and moving to type="module" guidance.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@frederikprijck frederikprijck requested a review from a team as a code owner August 14, 2023 15:12
Copy link
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Let's get this merged :)

@jonkoops
Copy link
Contributor

@frederikprijck looks like this still needs a review from someone on the Auth0 team, but it looks like the reviewers from the CODEOWNERS file were not automatically assigned?

@frederikprijck
Copy link
Member Author

frederikprijck commented Aug 15, 2023

Not sure what you mean ? It looks like it is waiting on a review of DX SDKs Engineers, which is correct.

This should be in their queue, depending on the time and priorities, it can take a little longer.

@frederikprijck frederikprijck merged commit 506ce6c into beta Aug 15, 2023
@frederikprijck frederikprijck deleted the feat/drop-umd branch August 15, 2023 12:10
@jonkoops
Copy link
Contributor

Hmmm, strange. I was not able to see a reviewer being assigned. Not sure why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants