Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop UMD bundle from distribution #191

Closed
wants to merge 1 commit into from
Closed

Conversation

jonkoops
Copy link
Contributor

This is a draft PR to show what it could look like if we were to drop the UMD bundle (see #190). Specifically, it would allow the elimination of a lot of dependencies (including Rollup), by switching fully to tsup.

@jonkoops jonkoops requested a review from a team as a code owner August 12, 2023 22:42
@jonkoops jonkoops marked this pull request as draft August 13, 2023 16:38
Copy link
Member

@frederikprijck frederikprijck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I know it's draft and will keep it open. But I believe dropping UMD and moving away from rollup are two different discussions. I understand the benefit of tsup, and will happily discuss this as well with the team, but as mention do know that we extensively use rollup in all our SDKs, and I dont see any strict need to drop rollup here that justifies the unalignment or the introduction of alignment work in all of our other SDKs.

Additionally, the npm run dev command does not work the same anymore, so we will need to bring that back if we were to drop rollup. But again, different conversation as it impacts our general tooling we use with our JavaScript libs/SDKs.

No need to make any changes here, I reached out internally and will get back to this PR.

@frederikprijck
Copy link
Member

frederikprijck commented Aug 14, 2023

Have had an internal conversation and we might want to see if #192 would be sufficient before considering a new bundler. Given the size of this library, we might not even need a bundler but the question is if this would cause any issues that TSUP would solve.

Will need to continue investigating this, but wanted to open a draft PR to allow for a conversation.

Long story short, we are okay to drop UMD but let's figure out the bundler.

@frederikprijck
Copy link
Member

I also dropped UMD on its own here: #193

@jonkoops
Copy link
Contributor Author

jonkoops commented Aug 14, 2023

I think it would be nice to have as little tooling as possible, so I certainly agree that the best option would be to simply rely on the TypeScript compiler 👍

@jonkoops
Copy link
Contributor Author

Closing this PR as I think #193 and #192 cover this better.

@jonkoops jonkoops closed this Aug 14, 2023
@jonkoops jonkoops deleted the drop-umd branch August 14, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants