Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tenant session_cookie property #88

Merged
merged 6 commits into from
Jul 11, 2022

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Jul 6, 2022

Description

Adding the session_cookie tenant property to enable the modification of session cookie behavior. This was originally requested in this Terraform provider issue.

This property is an object that contains a single mode property that accepts two string values: "persistent" and "non-persistent".

References

Testing

Tested manually and also added test case to existing TestTenantManager test.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have read and agreed to the terms within the Auth0 Code of Conduct.
  • I have read the Auth0 General Contribution Guidelines.
  • I have reviewed my own code beforehand.
  • I have added documentation for new/changed functionality in this PR.
  • All active GitHub checks for tests, formatting, and security are passing.
  • The correct base branch is being used, if not main.

@willvedd willvedd requested a review from a team as a code owner July 6, 2022 19:47
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2022

Codecov Report

Merging #88 (cce3689) into main (ef9a6af) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   94.73%   94.74%   +0.01%     
==========================================
  Files          33       33              
  Lines        5699     5711      +12     
==========================================
+ Hits         5399     5411      +12     
  Misses        240      240              
  Partials       60       60              
Impacted Files Coverage Δ
management/tenant.go 83.90% <ø> (ø)
management/management.gen.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef9a6af...cce3689. Read the comment docs.

Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

@sergiught sergiught changed the title Adding support for tenant session_cookie property Add support for tenant session_cookie property Jul 11, 2022
@sergiught sergiught merged commit 012e5fc into main Jul 11, 2022
@sergiught sergiught deleted the add-tenant-session-cookie branch July 11, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants