Add session_cookie to tenant

[willvedd]

Description

As pointed out in #55, the tenant resource is lacking support for modifying session cookie behavior. This PR adds this functionality through the session_cookie property. It mimics the Management API data shape with a single mode sub-property that accepts one of two strings: "persistent" or "non-persistent".

This configuration can be found in the dashboard by following the https://manage.auth0.com/dashboard/us/<YOUR_TENANT>/tenant/advanced route:

This depends on a similar PR to add functionality to the Go SDK.

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

• I have read and agreed to the terms within the Auth0 Code of Conduct

Auth0 General Contribution Guidelines

• I have read the Auth0 General Contribution Guidelines

Changes include test coverage?

• Yes
• Not needed

Does the description provide the correct amount of context?

• Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

• Yes, I've updated the appropriate docs
• Not needed

Is this code ready for production?

• Yes, all code changes are intentional and no debugging calls are left over

[codecov-commenter]

Codecov Report

Merging #220 (63c54ee) into main (7b53f6d) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
+ Coverage   83.63%   83.71%   +0.08%     
==========================================
  Files          36       36              
  Lines        6587     6620      +33     
==========================================
+ Hits         5509     5542      +33     
  Misses        859      859              
  Partials      219      219              

Impacted Files	Coverage Δ
auth0/resource_auth0_tenant.go	97.32% <100.00%> (+0.15%)	⬆️
auth0/structure_auth0_tenant.go	90.19% <100.00%> (+0.83%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b53f6d...63c54ee. Read the comment docs.

[sergiught]

Let's take @Widcket's suggestion to keep these kind of PRs in Draft mode till we make a release in go-auth0 SDK, wdyt? So we can easily differentiate between the ones that can be immediately merged and these that shouldn't yet.

[sergiught]

Do we really need computed both here and on the mode? 🤔

[willvedd]

I don't know, do we? Frankly, it's a confusing property that possesses unintuitive behavior; I'm seeing that we set many things to Computed: true so I'm just following a precedent.

[sergiught]

What we can do is try first the parameters without the computed property. The computed is usually needed if there are weird diffs constantly showing whenever terraform performs a refresh, that have no explanation (my personal heuristic on when to use computed or not).

[willvedd]

Turns out the computed property only needs to be enabled on the root object, not necessarily the children, or at least for this example. However, enabling for the child too did not alter behavior.

I'd prefer to not require manual verification testing for these types of additions, so I added a third stage for the TestAccTenant test. It attempts to apply an empty tenant resource block to see if it triggers any odd behavior from Terraform or the Management API. Specifically for this case, it caught a 400 error that occurred when Terrafrom attempted to set the session_cookie to an empty object, something that the Management API prohibits.

[sergiught]

We're sending an empty object because the expand func is flawed. We can remove the Computed property and refactor the expand as follows:

func expandTenantSessionCookie(d ResourceData) *management.TenantSessionCookie {
	var sessionCookie *management.TenantSessionCookie

	List(d, "session_cookie").Elem(func(d ResourceData) {
		sessionCookie = &management.TenantSessionCookie{Mode: String(d, "mode")}
	})

	return sessionCookie
}

This will make it so that sessionCookie is nil in case it's not present in the config so it will get omitted from the payload because of the omitempty tag.

[sergiught]

Suggested change

Computed: true,

[willvedd]

The suggested change to refactor expandTenantSessionCookie works, but it does not enable us to remove the Computed property because it fails the "reset" test stage. The plan is not empty afterwards. I'm going to opt to keep it as-is because there is no discernible change in code. Further, the code for that expand function matches the existing precedent set by expandTenantChangePassword, expandTenantGuardianMFAPage, expandTenantErrorPage and expandTenantUniversalLogin.

[sergiught]

Suggested change

	func expandTenantSessionCookie(d ResourceData) *management.TenantSessionCookie {
	var sessionCookie management.TenantSessionCookie
	List(d, "session_cookie").Elem(func(d ResourceData) {
	sessionCookie.Mode = String(d, "mode")
	})
	return &sessionCookie
	}
	func expandTenantSessionCookie(d ResourceData) *management.TenantSessionCookie {
	var sessionCookie *management.TenantSessionCookie
	List(d, "session_cookie").Elem(func(d ResourceData) {
	sessionCookie = &management.TenantSessionCookie{Mode: String(d, "mode")}
	})
	return sessionCookie
	}