Add custom marshal and unmarshal funcs to websocket message #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/auth0-universal-login-customize #880 +/- ##
==========================================================================
Coverage ? 72.47%
==========================================================================
Files ? 93
Lines ? 12288
Branches ? 0
==========================================================================
Hits ? 8906
Misses ? 2865
Partials ? 517 ☔ View full report in Codecov by Sentry. |
Widcket
approved these changes
Oct 16, 2023
Base automatically changed from
DXCDT-550-propagate-errors
to
feature/auth0-universal-login-customize
October 17, 2023 07:19
sergiught
force-pushed
the
DXCDT-550-refactor
branch
from
64357dc to
8425a56
Compare
sergiught
merged commit b86b485
into
feature/auth0-universal-login-customize
6 checks passed
sergiught
added a commit
that referenced
this pull request
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Add custom marshal and unmarshal funcs to websocket message to simplify code.
📚 References
🔬 Testing
📝 Checklist