DXCDT-550: Propagate errors through websocket connection #879
Conversation
| h.shutdown() | ||
| return | ||
| } | ||
| defer func() { | ||
| _ = connection.Close() |
There was a problem hiding this comment.
We weren't properly closing the connection before. This is really important to do.
| if websocket.IsCloseError(err, websocket.CloseNormalClosure, websocket.CloseGoingAway) || | ||
| websocket.IsUnexpectedCloseError(err, websocket.CloseAbnormalClosure) { | ||
| // The connection was closed. | ||
| break | ||
| } |
There was a problem hiding this comment.
This logic is needed in order to prevent a panic where we keep trying to read from a closed connection due to the for loop.
|
|
||
| errorMsg := webSocketMessage{ | ||
| Type: errorMessageType, | ||
| Payload: []byte(fmt.Sprintf(`{"error":%q}`, err.Error())), |
There was a problem hiding this comment.
Should we be using a struct to represent the error, and then JSON-encode it?
There was a problem hiding this comment.
Yep, we should. I plan to do that in a follow up PR and refactor the entire webSocketMessage so we can add custom JSON marshalling and unmarshalling and reuse the payload accordingly. This will prevent us from needing to unmarshal twice the message when we received it through the websocket as we're doing now.
The solution would be similar to what we do within the Go SDK for Connection Options.
|
|
||
| errorMsg := webSocketMessage{ | ||
| Type: errorMessageType, | ||
| Payload: []byte(fmt.Sprintf(`{"error":%q}`, err.Error())), |
sergiught
merged commit 64c08a4
into
feature/auth0-universal-login-customize
🔧 Changes
This PR adds the ability to propagate errors through the WebSocket connection to the Web App used through the
auth0 universal-logincustomize command. The payload of this message is as follows:{ "type": "ERROR", "payload": { "error": "information about what went wrong" } }📚 References
🔬 Testing
📝 Checklist