-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: log errors context #84
Merged
+10,429
−10,578
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0fe3644
vendors
turcottedanny 4076f09
vendors
turcottedanny 03e016f
Add more data to log description
turcottedanny 0e225ca
vendors
turcottedanny 7497d90
wire actionexecution
turcottedanny 4546bf1
Fix build failure
cyx ed35289
tidy + vendor
cyx 63d7362
BAM: add the JSON rows
cyx 986fbef
vendors
turcottedanny 0cdeb58
improve ux for actions logs
turcottedanny 636144a
v2 of actions logs
turcottedanny 81ec51a
stream experiment over: utilize "truncated" columns
cyx d52984b
Back to non-forked version of tablewriter
cyx 5db1c00
Docs on decorator
cyx 44ea453
Formatting
cyx 741a019
Back to const
cyx 67fa25d
Cleanup const declarations
cyx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| package actions | ||
|
|
||
| import ( | ||
| "errors" | ||
| "time" | ||
|
|
||
| "github.com/auth0/auth0-cli/internal/auth0" | ||
| "gopkg.in/auth0.v5/management" | ||
| ) | ||
|
|
||
| // NewSampledExecutionAPI creates a decorated ActionExecutionAPI which | ||
| // implements a leaky bucket based on the given interval. | ||
| func NewSampledExecutionAPI(api auth0.ActionExecutionAPI, interval time.Duration) auth0.ActionExecutionAPI { | ||
| return &sampledExecutionAPI{ | ||
| api: api, | ||
| interval: interval, | ||
| timer: time.NewTimer(0), | ||
| } | ||
| } | ||
|
|
||
| type sampledExecutionAPI struct { | ||
| auth0.ActionExecutionAPI | ||
|
|
||
| api auth0.ActionExecutionAPI | ||
|
|
||
| interval time.Duration | ||
| timer *time.Timer | ||
| } | ||
|
|
||
| // errRateLimited is returned whenever the leaky bucket isn't ready to drip. | ||
| var errRateLimited = errors.New("actions: rate limited") | ||
|
|
||
| // Read checks if the leaky bucket is ready to drip: if not, then an | ||
| // errRateLimited is returned. | ||
| func (a *sampledExecutionAPI) Read(id string) (*management.ActionExecution, error) { | ||
| select { | ||
| case <-a.timer.C: | ||
| a.timer.Reset(a.interval) | ||
| return a.api.Read(id) | ||
| default: | ||
| return nil, errRateLimited | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is likely a key pattern we can utilize for cases where we need to
N+1a query. For this particular case, actions execution information needs to be fetched as a separate API call since the log only contains the execution ID.