feat: log errors context #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's what logs look like when there's actions context available:
Users can silence the extended data:
Snippet of silent:
Snippet of default:
|
cyx
reviewed
Jan 28, 2021
Comment on lines
+11
to
+19
| // NewSampledExecutionAPI creates a decorated ActionExecutionAPI which | ||
| // implements a leaky bucket based on the given interval. | ||
| func NewSampledExecutionAPI(api auth0.ActionExecutionAPI, interval time.Duration) auth0.ActionExecutionAPI { | ||
| return &sampledExecutionAPI{ | ||
| api: api, | ||
| interval: interval, | ||
| timer: time.NewTimer(0), | ||
| } | ||
| } |
There was a problem hiding this comment.
This is likely a key pattern we can utilize for cases where we need to N+1 a query. For this particular case, actions execution information needs to be fetched as a separate API call since the log only contains the execution ID.
cyx
reviewed
Jan 28, 2021
|
|
||
| } | ||
|
|
||
| func (r *Renderer) Stream(data []View, ch <-chan View) { |
There was a problem hiding this comment.
Stream is now completely separate and will simply display rows in "tab separated" format"
cyx
reviewed
Jan 28, 2021
| fmt.Fprintf(w, fmtStr, args...) | ||
| } | ||
|
|
||
| func writeTable(w io.Writer, header []string, data [][]string) { |
There was a problem hiding this comment.
writeTable is back to its original form, without streaming concerns. (Thank god! :)
|
LGTM, but I can't approve this since I'm the owner of the PR |
cyx
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Extras() []stringconcept which aViewcan optionally implement.Streamimplementation).