Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Apps and first run logic from Tenant struct #742

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Apr 15, 2023

🔧 Changes

The ability to track when an application is used for the first time in a command was introduced in #199, however #302 erroneously removes the func call to actually persist that to the config, thus right now we always show the hint, regardless if we used the application multiple times with the same cli command.

Due to the fact that this was used only within auth0 test login command and it is now effectively broken and the fact that it adds unnecessary logic at the moment, in this PR we're removing it completely and always displaying the hint at the end.

This PR aids as well simplifying the work for a follow up PR that will refactor the Config logic into its own package.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.27 🎉

Comparison is base (4f88a7d) 70.90% compared to head (1078c79) 71.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
+ Coverage   70.90%   71.17%   +0.27%     
==========================================
  Files          87       87              
  Lines       11209    11162      -47     
==========================================
- Hits         7948     7945       -3     
+ Misses       2744     2700      -44     
  Partials      517      517              
Impacted Files Coverage Δ
internal/cli/cli.go 59.79% <ø> (+5.49%) ⬆️
internal/cli/test.go 44.82% <0.00%> (+3.19%) ⬆️
internal/display/test.go 46.34% <0.00%> (-11.24%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sergiught sergiught marked this pull request as ready for review April 15, 2023 14:40
@sergiught sergiught requested a review from a team as a code owner April 15, 2023 14:40
@sergiught sergiught merged commit e53b3d3 into main Apr 17, 2023
@sergiught sergiught deleted the patch/remove-apps-first-runs-tracking branch April 17, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants