Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a hint the first time test login runs [CLI-72] #199

Merged
merged 6 commits into from
Mar 26, 2021
Merged

Show a hint the first time test login runs [CLI-72] #199

merged 6 commits into from
Mar 26, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Mar 26, 2021

Description

This PR shows a hint the first time test login runs successfully, pointing the user towards the next step.

Screen Shot 2021-03-26 at 18 37 50

It does it by saving a flag in the CLI config file:

Screen Shot 2021-03-26 at 18 27 38

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team March 26, 2021 21:57
jfatta
jfatta approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Minor suggestion about errors handling.

internal/cli/cli.go Outdated Show resolved Hide resolved
@Widcket Widcket merged commit 5cbf783 into main Mar 26, 2021
@Widcket Widcket deleted the hint-first-test-login branch March 26, 2021 23:24
@sergiught sergiught mentioned this pull request Apr 15, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfatta jfatta jfatta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @jfatta