DXCDT-415: Quickstarts integration tests #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
==========================================
+ Coverage 58.11% 59.12% +1.01%
==========================================
Files 89 89
Lines 11497 11494 -3
==========================================
+ Hits 6681 6796 +115
+ Misses 4363 4219 -144
- Partials 453 479 +26
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
willvedd
commented
Mar 30, 2023
Comment on lines
-358
to
-361
| if !canPrompt(cmd) { | ||
| return errors.New("this command can only be run on interactive mode") | ||
| } | ||
|
|
There was a problem hiding this comment.
This conditional was originally added in #119 . It notes:
Returned an error when running in non-interactive mode
- The use case for this command only makes sense when run by a human being
- This can be changed later if other use cases pop up
I consider the removal of this check appropriate to enable testing IMO.
ewanharris
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
auth0 qs downloadintegration caseauth0 qs downloadto work in non-interactive environments🔬 Testing
All tests pass.
📝 Checklist