Fix quickstarts download issues [CLI-53] #119
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screen.Recording.2021-03-03.at.00.17.35.mov
Removed the 'type' flag and prompt
In the
quickstarts download
command, the first thing the code does is to use theclient-id
to fetch a Client instance from the Management API. In that instance, the app type is already available so there is no need to ask the user for it.Added a prompt for 'client-id'
The
client-id
could only be passed via flag while all the other inputs could be prompted. Also added a shorthand letter for the flag.Added a confirmation prompt before overriding
When the quickstart folder already existed, the command bailed out instructing the user to use the
--force
flag.Removed existing quickstart folder before unzipping
The existing files in the folder could cause an error.
Made texts consistent with other commands
Also edited them for clarity around what the command does. This command should probably be called
samples download
, though, since the quickstarts are tutorials that reference sample apps, but the sample apps are not quickstarts.Returned an error when running in non-interactive mode
Testing
Checklist
master