Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quickstarts download issues [CLI-53] #119

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Mar 3, 2021

Description

Screen.Recording.2021-03-03.at.00.17.35.mov

Removed the 'type' flag and prompt

In the quickstarts download command, the first thing the code does is to use the client-id to fetch a Client instance from the Management API. In that instance, the app type is already available so there is no need to ask the user for it.

Added a prompt for 'client-id'

The client-id could only be passed via flag while all the other inputs could be prompted. Also added a shorthand letter for the flag.

Added a confirmation prompt before overriding

When the quickstart folder already existed, the command bailed out instructing the user to use the --force flag.

Removed existing quickstart folder before unzipping

The existing files in the folder could cause an error.

Screen Shot 2021-03-03 at 00 10 22

Made texts consistent with other commands

Also edited them for clarity around what the command does. This command should probably be called samples download, though, since the quickstarts are tutorials that reference sample apps, but the sample apps are not quickstarts.

Returned an error when running in non-interactive mode

  • The use case for this command only makes sense when run by a human being
  • This can be changed later if other use cases pop up

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Thanks for doing this 💪

@Widcket Widcket merged commit 3faabc9 into main Mar 3, 2021
@Widcket Widcket deleted the polish-quickstarts branch March 3, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants