Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explode scopes per resource #34

Merged
merged 2 commits into from
Jan 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions internal/auth/auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,20 @@ const (
clientID = "2iZo3Uczt5LFHacKdM0zzgUO2eG2uDjT"
deviceCodeEndpoint = "https://auth0.auth0.com/oauth/device/code"
oauthTokenEndpoint = "https://auth0.auth0.com/oauth/token"
// TODO(jfatta) extend the scope as we extend the CLI:
scope = "openid create:actions create:clients create:resource_servers create:connections create:hooks create:rules delete:actions delete:clients delete:resource_servers delete:connections delete:hooks delete:rules read:actions read:clients read:resource_servers read:connections read:hooks read:logs read:rules update:actions update:clients update:resource_servers update:connections update:hooks update:rules"
audiencePath = "/api/v2/"
audiencePath = "/api/v2/"
)

var requiredScopes = []string{
"openid",
"create:actions", "delete:actions", "read:actions", "update:actions",
"create:clients", "delete:clients", "read:clients", "update:clients",
"create:connections", "delete:connections", "read:connections", "update:connections",
"create:hooks", "delete:hooks", "read:hooks", "update:hooks",
"create:resource_servers", "delete:resource_servers", "read:resource_servers", "update:resource_servers",
"create:rules", "delete:rules", "read:rules", "update:rules",
"read:client_keys", "read:logs",
}

type Authenticator struct {
}

Expand Down Expand Up @@ -124,7 +133,7 @@ func (a *Authenticator) Wait(ctx context.Context, state State) (Result, error) {
func (a *Authenticator) getDeviceCode(ctx context.Context) (State, error) {
data := url.Values{
"client_id": {clientID},
"scope": {scope},
"scope": {strings.Join(requiredScopes, " ")},
"audience": {"https://*.auth0.com/api/v2/"},
}
r, err := http.PostForm(deviceCodeEndpoint, data)
Expand Down
49 changes: 49 additions & 0 deletions internal/auth/auth_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
package auth

import "testing"

func TestRequiredScopes(t *testing.T) {
t.Run("verify CRUD", func(t *testing.T) {
crudResources := []string{
"actions",
"clients",
"connections",
"hooks",
"resource_servers",
"rules",
}
crudPrefixes := []string{"create:", "delete:", "read:", "update:"}

for _, resource := range crudResources {
for _, prefix := range crudPrefixes {
scope := prefix + resource

if !strInArray(requiredScopes, scope) {
t.Fatalf("wanted scope: %q, list: %+v", scope, requiredScopes)
}
}
}
})

t.Run("verify special scopes", func(t *testing.T) {
list := []string{
"read:client_keys", "read:logs",
}

for _, v := range list {
if !strInArray(requiredScopes, v) {
t.Fatalf("wanted scope: %q, list: %+v", v, requiredScopes)
}
}
})
}

func strInArray(haystack []string, needle string) bool {
for _, v := range haystack {
if v == needle {
return true
}
}

return false
}