Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explode scopes per resource #34

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Explode scopes per resource #34

merged 2 commits into from
Jan 26, 2021

Conversation

cyx
Copy link
Contributor

@cyx cyx commented Jan 26, 2021

This ideally makes the diffs more readable, but makes it clear which
resources we're trying to ask permissions for the future reader.

@cyx
Explode scopes per resource
c786040 
This ideally makes the diffs more readable, but makes it clear which
resources we're trying to ask permissions for the future reader.
@paddycarey
Copy link
Contributor

I think the read:client_keys scope has disappeared from the list somewhere along the line

@cyx
Copy link
Contributor Author

cyx commented Jan 26, 2021

I think the read:client_keys scope has disappeared from the list somewhere along the line

That's a signal: unit test added :)

@cyx cyx merged commit 3479993 into main Jan 26, 2021
@cyx cyx deleted the explode-scopes-per-resource branch January 26, 2021 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vprasanth vprasanth vprasanth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyx @paddycarey @vprasanth