Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps picker: allow configurability of default app #205

Merged
merged 3 commits into from
Mar 29, 2021

Conversation

cyx
Copy link
Contributor

@cyx cyx commented Mar 27, 2021

Closes #190

Demo

asciicast

@woloski
Copy link

woloski commented Mar 27, 2021

🔥chef kiss

@cyx cyx force-pushed the apps-picker-prefer-recent-app branch from d9e27a7 to ee4905f Compare March 27, 2021 20:05
internal/cli/apps.go Outdated Show resolved Hide resolved
@Widcket Widcket requested a review from a team March 29, 2021 13:33
@cyx cyx force-pushed the apps-picker-prefer-recent-app branch from 613a3dd to c90eb6f Compare March 29, 2021 16:10
internal/cli/apps.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a fix for a typo, otherwise LGTM.

Co-authored-by: Rita Zerrizuela <[email protected]>
@Widcket Widcket merged commit 734443a into main Mar 29, 2021
@Widcket Widcket deleted the apps-picker-prefer-recent-app branch March 29, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants