Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep "last client id created" in memory and offer that as the default for commands that require client ID [CLI-91] #190

Closed
woloski opened this issue Mar 24, 2021 · 5 comments · Fixed by #205
Assignees
Labels
enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature

Comments

@woloski
Copy link

woloski commented Mar 24, 2021

image

Instead of having to find the client id, we can offer the last client created as the default option (just store it in a global var in memory). Anywhere where we ask for client ID we should default to that. Delighter.

@Widcket Widcket added the enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature label Mar 24, 2021
@Widcket
Copy link
Contributor

Widcket commented Mar 24, 2021

We can store it in the config file so it survives across command invocations.

@Widcket
Copy link
Contributor

Widcket commented Mar 24, 2021

Also, we can use it to set a default value in the picker (otherwise just the Client Id, devoid of all context, may be confusing to the dev that may no realize it is the Id of the app recently created).

@woloski
Copy link
Author

woloski commented Mar 24, 2021 via email

@Widcket
Copy link
Contributor

Widcket commented Mar 24, 2021

This might have to be accompanied by an auth0 apps use <client-id> otherwise there's no way to change/unset it.

@Widcket Widcket changed the title keep "last client id created" in memory and offer that as the default for commands that require client ID Keep "last client id created" in memory and offer that as the default for commands that require client ID [CLI-91] Mar 26, 2021
@Widcket
Copy link
Contributor

Widcket commented Mar 26, 2021

Tracking in CLI-91.

cyx added a commit that referenced this issue Mar 27, 2021
cyx added a commit that referenced this issue Mar 27, 2021
@cyx cyx self-assigned this Mar 27, 2021
cyx added a commit that referenced this issue Mar 27, 2021
cyx added a commit that referenced this issue Mar 29, 2021
Widcket added a commit that referenced this issue Mar 29, 2021
* apps picker: allow configurability of default app

Closes #190

* Show hint with the client id

* Update internal/cli/apps.go

Co-authored-by: Rita Zerrizuela <[email protected]>

Co-authored-by: Rita Zerrizuela <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants