Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special-case the Angular port on qs download #194

Merged
merged 3 commits into from
Mar 26, 2021
Merged

Special-case the Angular port on qs download #194

merged 3 commits into from
Mar 26, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Mar 26, 2021

Description

quickstarts download includes a prompt to ask the user if the required URLs (callback, logout and allowed web origins) should be added to the Auth0 app in question. By convention, the default port for Angular apps is 4200 instead of 3000. This PR uses that port for Angular apps, instead of the CLI default (3000).

See auth0-samples/auth0-angular-samples#225 (comment).

Screen Shot 2021-03-26 at 16 09 34

Screen Shot 2021-03-26 at 16 10 06

References

auth0-samples/auth0-angular-samples#225

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team March 26, 2021 19:20
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Widcket Widcket merged commit 770f1aa into main Mar 26, 2021
@Widcket Widcket deleted the angular-port branch March 26, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants