Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we move the web app to port 3000? #225

Closed
woloski opened this issue Mar 24, 2021 · 4 comments
Closed

can we move the web app to port 3000? #225

woloski opened this issue Mar 24, 2021 · 4 comments

Comments

@woloski
Copy link

woloski commented Mar 24, 2021

We are creating the callback URL automatically when a user downloads a QS from the CLI and the port is fixed to localhost:3000. Can we change it instead of using 4200?

@frederikprijck
Copy link
Contributor

frederikprijck commented Mar 25, 2021

Hi @woloski,

We could do that, I am a bit concerned about the confusion this might give to Angular users. I know it's only a port, but angular is known to run their application on 4200, I am pretty convinced not using 4200 will confuse people as pretty much all angular docs will always refer to 4200. As some of our audience also involves people less familiar with Angular, I believe sticking to Angular defaults can improve DX for them.

I am happy to change the port to 3000, but before doing so I wanted to check if there is a possibility to have the CLI use 4200 for Angular instead to ensure we align with the Angular defaults rather than adapt for our own tooling.

If that isn't an option or creates unnecessary complexity on the CLI side, I am happy to change the port. But I wanted to verify before doing so.

@woloski
Copy link
Author

woloski commented Mar 26, 2021

hmmm I see. @Widcket not sure how complex would it be to change the default URL in the CLI "if Angular".

@Widcket
Copy link
Contributor

Widcket commented Mar 26, 2021

@woloski not much, can squeeze it in today

@frederikprijck
Copy link
Contributor

Cool thanks @Widcket , I will close this but let me know if you need anything from me for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants