While perusing found this subtle bug #176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should be comparing the name as well.
Widcket
reviewed
Mar 20, 2021
| @@ -366,7 +366,7 @@ func shouldPromptWhenFlagless(cmd *cobra.Command, flag string) bool { | |||
| isSet := false | |||
|
|
|||
| cmd.LocalFlags().VisitAll(func(f *pflag.Flag) { | |||
| if f.Changed { | |||
| if f.Name == flag && f.Changed { | |||
There was a problem hiding this comment.
This visits all the flag and if any is set, it takes it in account for the return value. If we check for the name, aren't we only taking in account the status of that single flag?
Context: #130 (comment)
There was a problem hiding this comment.
Hmm, I see. Ok we can close this totally misunderstood the intent of this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be comparing the name as well.