Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating callback urls [CLI-56] #130

Closed
woloski opened this issue Mar 5, 2021 · 4 comments · Fixed by #136
Closed

updating callback urls [CLI-56] #130

woloski opened this issue Mar 5, 2021 · 4 comments · Fixed by #136
Labels
enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature

Comments

@woloski
Copy link

woloski commented Mar 5, 2021

If I do this, I expect to just add a callback URL to this app.
go run ./cmd/auth0 apps update ngKKhR5yy9fvIXnjRzEYdJZ7YGwjheQ8 -c http://localhost:3000

Instead it will prompt me also for name, description, etc.

Also, if I do go run ./cmd/auth0 apps update ngKKhR5yy9fvIXnjRzEYdJZ7YGwjheQ8 I would expect to get asked name, description, type AND callback URLs (right now it doesn't ask for that).

@Widcket
Copy link
Contributor

Widcket commented Mar 5, 2021

@woloski so you say that for update operations we should not ask for the value if the flag is missing, only if no flags were provided at all (even if it's a required field)? And when called with no flags (and thus prompting) it should ask for every supported property (even if it's not a required field)?

@woloski
Copy link
Author

woloski commented Mar 5, 2021

  1. yes
  2. only for callback URLs (which is an important prop)

@Widcket
Copy link
Contributor

Widcket commented Mar 5, 2021

Ok, working on it.

@Widcket Widcket changed the title updating callback urls updating callback urls [CLI-56] Mar 5, 2021
@Widcket
Copy link
Contributor

Widcket commented Mar 5, 2021

Tracking on CLI-56.

@Widcket Widcket added the enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature label Mar 5, 2021
@cyx cyx closed this as completed in #136 Mar 6, 2021
This was referenced Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants