Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: offer to add default urls for quickstart #155

Merged
merged 12 commits into from
Mar 16, 2021

Conversation

as-herzog
Copy link
Contributor

@as-herzog as-herzog commented Mar 12, 2021

Description

Add prompts to update an application's allowed urls to include localhost:3000 after downloading quickstart.

Screen Shot 2021-03-15 at 8 25 34 AM

No prompt if the URLs have already been added
Screen Shot 2021-03-15 at 8 15 20 AM

  • Add prompts for adding url
  • Check if urls already exist before prompting

References

#128

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@woloski
Copy link

woloski commented Mar 12, 2021

I would make it a single question for the three props

@as-herzog as-herzog marked this pull request as ready for review March 15, 2021 14:31
internal/cli/quickstarts.go Outdated Show resolved Hide resolved
@Widcket Widcket requested a review from jfatta March 15, 2021 17:43
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a minor suggestion inline, then 📦 :shipit:

internal/cli/quickstarts.go Outdated Show resolved Hide resolved
@as-herzog as-herzog merged commit e4e613c into main Mar 16, 2021
@as-herzog as-herzog deleted the CLI59-offer-default-urls-QS branch March 16, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants