Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for adding callback on quickstart download [CLI-59] #128

Closed
woloski opened this issue Mar 5, 2021 · 7 comments
Closed

Ask for adding callback on quickstart download [CLI-59] #128

woloski opened this issue Mar 5, 2021 · 7 comments
Labels
enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature

Comments

@woloski
Copy link

woloski commented Mar 5, 2021

Once quickstart is download before finishing ask Do you want to add this URL to the list of allowed callback URLs: http://localhost:3000?

@woloski woloski added the enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature label Mar 5, 2021
@Widcket
Copy link
Contributor

Widcket commented Mar 8, 2021

Good idea, but only for web apps and SPAs, as in mobile custom schemes are used.

@Widcket
Copy link
Contributor

Widcket commented Mar 8, 2021

Added the card CLI-59 to track this.

@Widcket Widcket changed the title ask for adding callback on quickstart download Ask for adding callback on quickstart download [CLI-59] Mar 8, 2021
@Widcket
Copy link
Contributor

Widcket commented Mar 8, 2021

Describing this task as:

Once a quickstart has finished downloading, before finishing:

  • If the app is a SPA, ask:

    • Do you want to add this URL to the list of allowed callback URLs: http://localhost:3000?
    • Do you want to add this URL to the list of allowed logout URLs: http://localhost:3000?
    • Do you want to add this URL to the list of allowed web origins: http://localhost:3000?
  • If the app is a Regular Web App, ask:

    • Do you want to add this URL to the list of allowed callback URLs: http://localhost:3000?
    • Do you want to add this URL to the list of allowed logout URLs: http://localhost:3000?

Because all those are needed (with those values) to get the app running.

@woloski
Copy link
Author

woloski commented Mar 12, 2021

can we do this one?

@Widcket
Copy link
Contributor

Widcket commented Mar 12, 2021

The card is already picked up and on the "In Progress" lane.

@as-herzog
Copy link
Contributor

@Widcket I started a draft for it but I need to run right now. Feel free to continue off my draft, otherwise I will complete it over the weekend or early next week.

Needs a check for if the urls already exist (will throw an error if they do) and tests.

@Widcket
Copy link
Contributor

Widcket commented Mar 23, 2021

Implemented in #155.

@Widcket Widcket closed this as completed Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature
Projects
None yet
Development

No branches or pull requests

3 participants