-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-2161] Allow to skip the redirect callback #86
Changes from 2 commits
466b127
9fbf009
48621a2
5710d2e
be7e926
4cb2770
19ff79b
58ff1e1
6b14f6c
0bff001
43b9b6c
0ce580c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,7 @@ import { | |
const authConfig: AuthConfig = { | ||
clientId: 'wLSIP47wM39wKdDmOj6Zb5eSEw3JVhVp', | ||
domain: 'brucke.auth0.com', | ||
skipRedirectCallback: window.location.pathname === '/other-callback', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need to have a route set up to handle this? How does this work in the playground from a user's perspective? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you want to use this, yes you do. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In that case it might be better to instead show a usage example in the docs against the new property - I can imagine people will look there first before they dive into the playground code. Do you think this also merits a section in the readme about usage with other providers? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
}; | ||
|
||
/** | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about our other conversations we've had about mocking less, do we need to use a Spy here or can we just give it an an instance of
AuthClientConfig
with the right config?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the config is different between tests, mocking it makes it a bit easier I think.