[SDK-2161] Allow to skip the redirect callback #86
Conversation
| @@ -17,6 +17,7 @@ import { | |||
| const authConfig: AuthConfig = { | |||
| clientId: 'wLSIP47wM39wKdDmOj6Zb5eSEw3JVhVp', | |||
| domain: 'brucke.auth0.com', | |||
| skipRedirectCallback: window.location.pathname === '/other-callback', | |||
There was a problem hiding this comment.
Do we need to have a route set up to handle this? How does this work in the playground from a user's perspective?
There was a problem hiding this comment.
If you want to use this, yes you do.
I added it to the playground as a matter of showing how to configure it, but we do not realy integrate our playground with another OAuth provider tho.
There was a problem hiding this comment.
In that case it might be better to instead show a usage example in the docs against the new property - I can imagine people will look there first before they dive into the playground code.
Do you think this also merits a section in the readme about usage with other providers?
There was a problem hiding this comment.
Yes I think that is a good idea and I updated the PR.
API Docs:
README:
| { | ||
| provide: AuthClientConfig, | ||
| useValue: authClientConfigSpy, | ||
| }, |
There was a problem hiding this comment.
Thinking about our other conversations we've had about mocking less, do we need to use a Spy here or can we just give it an an instance of AuthClientConfig with the right config?
There was a problem hiding this comment.
As the config is different between tests, mocking it makes it a bit easier I think.
| @@ -311,7 +312,7 @@ export class MyComponent { | |||
| } | |||
| ``` | |||
|
|
|||
| ## Dynamic Configuration | |||
| ### Dynamic Configuration | |||
There was a problem hiding this comment.
It looks like this header was wrong, updated it to be the same level of heading as the other titles.
|
Updated the PR to avoid mocking the config. |
Co-authored-by: Steve Hobbs <[email protected]>
Co-authored-by: Steve Hobbs <[email protected]>
Co-authored-by: Steve Hobbs <[email protected]>
When using multiple OAuth providers on the same page, it happens that another provider redirects back to a certain URL, including state and code parameters.
Currently, our SDK processed this and tries to retrieve a token. However, it should ignore these as they do not belong to Auth0.