ADM-718[frontend][stub]feat: Display verification results of ‘board’ #985

K-Chow · 2024-01-24T11:38:38Z

Summary

...

Before

Description

Screenshots
If applicable, add screenshots to help explain behavior of your code.

After

Description

Screenshots
If applicable, add screenshots to help explain behavior of your code.

Note

Null

github-actions · 2024-01-24T11:38:56Z

Hi @K-Chow! 👋
Thank you for submitting a pull request! We appreciate your contribution and will review your changes as soon as possible.

codacy-production · 2024-01-24T12:42:45Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.00%	✅ 100.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`e41ff49`)	5539	5539	100.00%
Head commit (`8c685ed`)	5593 (+54)	5593 (+54)	100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#985)	159	159	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation}

guzhongren

change with the comments

frontend/__tests__/containers/ConfigStep/Board.test.tsx

frontend/src/containers/MetricsStep/index.tsx

frontend/src/context/config/configSlice.ts

frontend/src/hooks/useGetBoardInfo.ts

frontend/src/hooks/useVerifyBoardEffect.ts

stubs/backend/jira/jira-stubs.yaml

frontend/__tests__/client/BoardClient.test.ts

frontend/__tests__/containers/ConfigStep/Board.test.tsx

frontend/__tests__/components/Common/EmptyContent/EmptyContent.test.tsx

frontend/__tests__/containers/ConfigStep/ConfigStep.test.tsx

frontend/__tests__/hooks/useVerifyBoardEffect.test.tsx

frontend/src/constants/resources.ts

frontend/src/containers/MetricsStep/Crews/index.tsx

frontend/src/hooks/useGetBoardInfo.ts

frontend/src/hooks/useVerifyBoardEffect.ts

* ADM-747: [frontend] refactor: refactor notification * ADM-747: [frontend] refactor: set default title for notification * ADM-747: [frontend] feat: handle timeout error * ADM-747: [frontend] feat: handle report error * ADM-747: [frontend] refactor: rename reportMetricsError * ADM-747: [frontend] refactor: replace enum with object * ADM-747: [frontend] feat: handle report error * ADM-747: [frontend] feat: handle export error * ADM-747: [frontend] test: add tests for error notifications * ADM-747: [frontend] refactor: refactor report useEffect * ADM-747: [frontend] refactor: refactor TimeoutException * ADM-747: [frontend] refactor: delete useless isServerError * ADM-747: [frontend] test: add e2e tests for date picker * ADM-747: [frontend] fix: fix import

frontend/src/context/config/configSlice.ts

SimonTal

Approved

…985) * [kai.zhou][adm-718] feat: remove project key field * [kai.zhou][adm-718]: feat: add addtional key for form field * [kai.zhou][adm-718] fix unit test * [kai.zhou][adm-718]: fix: ignore no coverage function * [kai.zhou][adm-718]: feat: start integrate info api * [kai.zhou][adm-718]: fix: fix code typo * [kai.zhou][adm-718]: feat: update error handle for verify api * [kai.zhou][adm-718]: feat: refact valid rule * [kai.zhou][adm-718]: update get info callback * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: create new empty content component * [kai.zhou][adm-718]: test: fix some unit test * ADM-747: [frontend] feat: handle error (#968) * ADM-747: [frontend] refactor: refactor notification * ADM-747: [frontend] refactor: set default title for notification * ADM-747: [frontend] feat: handle timeout error * ADM-747: [frontend] feat: handle report error * ADM-747: [frontend] refactor: rename reportMetricsError * ADM-747: [frontend] refactor: replace enum with object * ADM-747: [frontend] feat: handle report error * ADM-747: [frontend] feat: handle export error * ADM-747: [frontend] test: add tests for error notifications * ADM-747: [frontend] refactor: refactor report useEffect * ADM-747: [frontend] refactor: refactor TimeoutException * ADM-747: [frontend] refactor: delete useless isServerError * ADM-747: [frontend] test: add e2e tests for date picker * ADM-747: [frontend] fix: fix import * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: create new empty content component * [kai.zhou][adm-718]: test: fix some unit test * [kai.zhou][adm-718]: chroe: format code * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: create new empty content component * [kai.zhou][adm-718]: test: fix some unit test * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: test: fix some unit test * [kai.zhou][adm-718]: chroe: format code * [kai.zhou][adm-718]: fix failed unit test * [kai.zhou][adm-718]: add new stub for jira verify * [kai.zhou][adm-718]: fix failed unit test * [kai.zhou][adm-718]: add unit test for useVerifyBoardEffect * [kai.zhou][adm-718]: fix unit test coverage * [kai.zhou][adm-718]: update e2e test * [kai.zhou][adm-718]: update e2e stub * [kai.zhou][adm-718]: update stub data * ADM-718:[Frontend] Fix E2E stub data * ADM-718:[Frontend] Fix E2E stub data * ADM-718:[Frontend] Fix E2E stub data * [kai.zhou][adm-718]: fix email fields not post and ignore some e2e script * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: create new empty content component * [kai.zhou][adm-718]: test: fix some unit test * ADM-747: [frontend] feat: handle error (#968) * ADM-747: [frontend] refactor: refactor notification * ADM-747: [frontend] refactor: set default title for notification * ADM-747: [frontend] feat: handle timeout error * ADM-747: [frontend] feat: handle report error * ADM-747: [frontend] refactor: rename reportMetricsError * ADM-747: [frontend] refactor: replace enum with object * ADM-747: [frontend] feat: handle report error * ADM-747: [frontend] feat: handle export error * ADM-747: [frontend] test: add tests for error notifications * ADM-747: [frontend] refactor: refactor report useEffect * ADM-747: [frontend] refactor: refactor TimeoutException * ADM-747: [frontend] refactor: delete useless isServerError * ADM-747: [frontend] test: add e2e tests for date picker * ADM-747: [frontend] fix: fix import * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: test: fix some unit test * [kai.zhou][adm-718]: chroe: format code * [ADM-740] show not show real done when cycle time by status (#972) Co-authored-by: wenjing-qi <[email protected]> * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: create new empty content component * [kai.zhou][adm-718]: test: fix some unit test * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: test: fix some unit test * [kai.zhou][adm-718]: chroe: format code * [kai.zhou][adm-718]: fix failed unit test * [kai.zhou][adm-718]: fix unit test coverage * [kai.zhou][adm-718]: fix typo * [kai.zhou][adm-718]: fix local conflict * [kai.zhou][adm-718]: fix failed test * [kai.zhou][adm-718]: fix type * [kai.zhou][adm-718]: fix code for review * [kai.zhou][adm-718]: fix test typo * [kai.zhou][adm-718]: fix code styles * [kai.zhou][adm-718]: fix failed test * [kai.zhou][adm-718]: refact email token mix * [kai.zhou][adm-718]: add new test case * [kai.zhou][adm-718]: fix code styles * [kai.zhou][adm-718]: skip e2e test for creat project * [kai.zhou][adm-718]: fix pr issue * [kai.zhou][adm-718]: fix codacy issue * [kai.zhou][adm-718]: fix codacy issue * [kai.zhou][adm-718]: fix codacy issue * [kai.zhou][adm-718]: fix codacy issue * [kai.zhou][adm-718]: fix failed test * [kai.zhou][adm-718]: refact unit test * ADM-718:[Frontend] Fix Codacy issue * ADM-718:[Frontend] Fix rebase issue * ADM-718:[Frontend] Fix test case * [kai.zhou][adm-718]: fix not show form error * [kai.zhou][adm-718]: fix issues about deskcheck * ADM-718:[Frontend] Fix unit test case * [kai.zhou]: support reset error message when change form field * [kai.zhou][adm-718]: fix failed test * [kai.zhou][adm-718]: fix Classification can not update * [kai.zhou][adm-718]: refact unit test for classification * [kai.zhou][adm-718]: fix failed lint * [kai.zhou][adm-718]: fix lint warning * ADM-718:[Frontend] Remove some comments for E2E tests * [kai.zhou][adm-718]: fix form field warning --------- Co-authored-by: 姜如 <[email protected]> Co-authored-by: Simon Tal <[email protected]> Co-authored-by: gabralia <[email protected]> Co-authored-by: wenjing-qi <[email protected]>

K-Chow force-pushed the feat/adm-718 branch from a0a133d to 805a976 Compare January 24, 2024 12:40

guzhongren reviewed Jan 24, 2024

View reviewed changes

SimonTal reviewed Jan 26, 2024

View reviewed changes

SimonTal changed the title ~~Feat/adm 718~~ ADM-718[frontend][stub]feat: Display verification results of ‘board’ Jan 26, 2024

Kai Zhou and others added 24 commits January 30, 2024 10:21

[kai.zhou][adm-718] feat: remove project key field

9c4f7fe

[kai.zhou][adm-718]: feat: add addtional key for form field

97f5e6f

[kai.zhou][adm-718] fix unit test

3eb1c39

[kai.zhou][adm-718]: fix: ignore no coverage function

4d8c641

[kai.zhou][adm-718]: feat: start integrate info api

878cd2a

[kai.zhou][adm-718]: fix: fix code typo

030aec0

[kai.zhou][adm-718]: feat: update error handle for verify api

cf9979c

[kai.zhou][adm-718]: feat: refact valid rule

b546f4f

[kai.zhou][adm-718]: update get info callback

6a84b19

[kai.zhou][adm-718]: refact board info call in metric page

cbf88a7

[kai.zhou][adm-718]: create new empty content component

e55403e

[kai.zhou][adm-718]: test: fix some unit test

d452489

[kai.zhou][adm-718]: refact board info call in metric page

44a959e

[kai.zhou][adm-718]: create new empty content component

82bae28

[kai.zhou][adm-718]: test: fix some unit test

e1af997

[kai.zhou][adm-718]: chroe: format code

0e93a10

[kai.zhou][adm-718]: refact board info call in metric page

462151f

[kai.zhou][adm-718]: create new empty content component

0d4cdca

[kai.zhou][adm-718]: test: fix some unit test

164962d

[kai.zhou][adm-718]: refact board info call in metric page

c7c9404

[kai.zhou][adm-718]: test: fix some unit test

ff4211d

[kai.zhou][adm-718]: chroe: format code

3b50a2a

[kai.zhou][adm-718]: fix failed unit test

6f80293

Kai Zhou and others added 9 commits January 30, 2024 10:52

[kai.zhou][adm-718]: fix pr issue

397818f

[kai.zhou][adm-718]: fix codacy issue

00d5083

[kai.zhou][adm-718]: fix codacy issue

f8cb785

[kai.zhou][adm-718]: fix codacy issue

d4fb247

[kai.zhou][adm-718]: fix codacy issue

0d7d5b4

[kai.zhou][adm-718]: fix failed test

81f089a

[kai.zhou][adm-718]: refact unit test

ff8b1b3

ADM-718:[Frontend] Fix Codacy issue

e033db7

ADM-718:[Frontend] Fix rebase issue

f1b1a50

SimonTal force-pushed the feat/adm-718 branch from 520d479 to f1b1a50 Compare January 30, 2024 03:03

SimonTal and others added 14 commits January 30, 2024 11:07

ADM-718:[Frontend] Fix test case

89a799f

[kai.zhou][adm-718]: fix not show form error

a358b60

[kai.zhou][adm-718]: fix issues about deskcheck

1e96503

ADM-718:[Frontend] Fix unit test case

35d9121

[kai.zhou]: support reset error message when change form field

729cd14

[kai.zhou][adm-718]: fix failed test

914144a

[kai.zhou][adm-718]: fix Classification can not update

e1aa434

[kai.zhou][adm-718]: refact unit test for classification

d1c2eaf

Merge branch 'main' into feat/adm-718

5793f11

[kai.zhou][adm-718]: fix failed lint

84afc3b

[kai.zhou][adm-718]: fix lint warning

30fee84

Merge branch 'main' into feat/adm-718

f26505d

ADM-718:[Frontend] Remove some comments for E2E tests

757712e

[kai.zhou][adm-718]: fix form field warning

8457000

SimonTal reviewed Feb 1, 2024

View reviewed changes

frontend/src/context/config/configSlice.ts Show resolved Hide resolved

Merge branch 'main' into feat/adm-718

8c685ed

SimonTal approved these changes Feb 1, 2024

View reviewed changes

SimonTal merged commit 2447ec8 into main Feb 1, 2024
28 checks passed

SimonTal deleted the feat/adm-718 branch February 1, 2024 07:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ADM-718[frontend][stub]feat: Display verification results of ‘board’ #985

ADM-718[frontend][stub]feat: Display verification results of ‘board’ #985

K-Chow commented Jan 24, 2024

github-actions bot commented Jan 24, 2024

codacy-production bot commented Jan 24, 2024 •

edited

Loading

guzhongren left a comment

SimonTal left a comment

ADM-718[frontend][stub]feat: Display verification results of ‘board’ #985

ADM-718[frontend][stub]feat: Display verification results of ‘board’ #985

Conversation

K-Chow commented Jan 24, 2024

Summary

Before

After

Note

github-actions bot commented Jan 24, 2024

codacy-production bot commented Jan 24, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

guzhongren left a comment

Choose a reason for hiding this comment

SimonTal left a comment

Choose a reason for hiding this comment

codacy-production bot commented Jan 24, 2024 •

edited

Loading