-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADM-740] show not show real done when cycle time by status #972
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
Hi @gabralia! 👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved without comments
Co-authored-by: wenjing-qi <[email protected]>
Co-authored-by: wenjing-qi <[email protected]>
Co-authored-by: wenjing-qi <[email protected]>
Co-authored-by: wenjing-qi <[email protected]>
Co-authored-by: wenjing-qi <[email protected]>
Co-authored-by: wenjing-qi <[email protected]>
Co-authored-by: wenjing-qi <[email protected]>
Co-authored-by: wenjing-qi <[email protected]>
…985) * [kai.zhou][adm-718] feat: remove project key field * [kai.zhou][adm-718]: feat: add addtional key for form field * [kai.zhou][adm-718] fix unit test * [kai.zhou][adm-718]: fix: ignore no coverage function * [kai.zhou][adm-718]: feat: start integrate info api * [kai.zhou][adm-718]: fix: fix code typo * [kai.zhou][adm-718]: feat: update error handle for verify api * [kai.zhou][adm-718]: feat: refact valid rule * [kai.zhou][adm-718]: update get info callback * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: create new empty content component * [kai.zhou][adm-718]: test: fix some unit test * ADM-747: [frontend] feat: handle error (#968) * ADM-747: [frontend] refactor: refactor notification * ADM-747: [frontend] refactor: set default title for notification * ADM-747: [frontend] feat: handle timeout error * ADM-747: [frontend] feat: handle report error * ADM-747: [frontend] refactor: rename reportMetricsError * ADM-747: [frontend] refactor: replace enum with object * ADM-747: [frontend] feat: handle report error * ADM-747: [frontend] feat: handle export error * ADM-747: [frontend] test: add tests for error notifications * ADM-747: [frontend] refactor: refactor report useEffect * ADM-747: [frontend] refactor: refactor TimeoutException * ADM-747: [frontend] refactor: delete useless isServerError * ADM-747: [frontend] test: add e2e tests for date picker * ADM-747: [frontend] fix: fix import * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: create new empty content component * [kai.zhou][adm-718]: test: fix some unit test * [kai.zhou][adm-718]: chroe: format code * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: create new empty content component * [kai.zhou][adm-718]: test: fix some unit test * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: test: fix some unit test * [kai.zhou][adm-718]: chroe: format code * [kai.zhou][adm-718]: fix failed unit test * [kai.zhou][adm-718]: add new stub for jira verify * [kai.zhou][adm-718]: fix failed unit test * [kai.zhou][adm-718]: add unit test for useVerifyBoardEffect * [kai.zhou][adm-718]: fix unit test coverage * [kai.zhou][adm-718]: update e2e test * [kai.zhou][adm-718]: update e2e stub * [kai.zhou][adm-718]: update stub data * ADM-718:[Frontend] Fix E2E stub data * ADM-718:[Frontend] Fix E2E stub data * ADM-718:[Frontend] Fix E2E stub data * [kai.zhou][adm-718]: fix email fields not post and ignore some e2e script * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: create new empty content component * [kai.zhou][adm-718]: test: fix some unit test * ADM-747: [frontend] feat: handle error (#968) * ADM-747: [frontend] refactor: refactor notification * ADM-747: [frontend] refactor: set default title for notification * ADM-747: [frontend] feat: handle timeout error * ADM-747: [frontend] feat: handle report error * ADM-747: [frontend] refactor: rename reportMetricsError * ADM-747: [frontend] refactor: replace enum with object * ADM-747: [frontend] feat: handle report error * ADM-747: [frontend] feat: handle export error * ADM-747: [frontend] test: add tests for error notifications * ADM-747: [frontend] refactor: refactor report useEffect * ADM-747: [frontend] refactor: refactor TimeoutException * ADM-747: [frontend] refactor: delete useless isServerError * ADM-747: [frontend] test: add e2e tests for date picker * ADM-747: [frontend] fix: fix import * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: test: fix some unit test * [kai.zhou][adm-718]: chroe: format code * [ADM-740] show not show real done when cycle time by status (#972) Co-authored-by: wenjing-qi <[email protected]> * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: create new empty content component * [kai.zhou][adm-718]: test: fix some unit test * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: test: fix some unit test * [kai.zhou][adm-718]: chroe: format code * [kai.zhou][adm-718]: fix failed unit test * [kai.zhou][adm-718]: fix unit test coverage * [kai.zhou][adm-718]: fix typo * [kai.zhou][adm-718]: fix local conflict * [kai.zhou][adm-718]: fix failed test * [kai.zhou][adm-718]: fix type * [kai.zhou][adm-718]: fix code for review * [kai.zhou][adm-718]: fix test typo * [kai.zhou][adm-718]: fix code styles * [kai.zhou][adm-718]: fix failed test * [kai.zhou][adm-718]: refact email token mix * [kai.zhou][adm-718]: add new test case * [kai.zhou][adm-718]: fix code styles * [kai.zhou][adm-718]: skip e2e test for creat project * [kai.zhou][adm-718]: fix pr issue * [kai.zhou][adm-718]: fix codacy issue * [kai.zhou][adm-718]: fix codacy issue * [kai.zhou][adm-718]: fix codacy issue * [kai.zhou][adm-718]: fix codacy issue * [kai.zhou][adm-718]: fix failed test * [kai.zhou][adm-718]: refact unit test * ADM-718:[Frontend] Fix Codacy issue * ADM-718:[Frontend] Fix rebase issue * ADM-718:[Frontend] Fix test case * [kai.zhou][adm-718]: fix not show form error * [kai.zhou][adm-718]: fix issues about deskcheck * ADM-718:[Frontend] Fix unit test case * [kai.zhou]: support reset error message when change form field * [kai.zhou][adm-718]: fix failed test * [kai.zhou][adm-718]: fix Classification can not update * [kai.zhou][adm-718]: refact unit test for classification * [kai.zhou][adm-718]: fix failed lint * [kai.zhou][adm-718]: fix lint warning * ADM-718:[Frontend] Remove some comments for E2E tests * [kai.zhou][adm-718]: fix form field warning --------- Co-authored-by: 姜如 <[email protected]> Co-authored-by: Simon Tal <[email protected]> Co-authored-by: gabralia <[email protected]> Co-authored-by: wenjing-qi <[email protected]>
…985) * [kai.zhou][adm-718] feat: remove project key field * [kai.zhou][adm-718]: feat: add addtional key for form field * [kai.zhou][adm-718] fix unit test * [kai.zhou][adm-718]: fix: ignore no coverage function * [kai.zhou][adm-718]: feat: start integrate info api * [kai.zhou][adm-718]: fix: fix code typo * [kai.zhou][adm-718]: feat: update error handle for verify api * [kai.zhou][adm-718]: feat: refact valid rule * [kai.zhou][adm-718]: update get info callback * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: create new empty content component * [kai.zhou][adm-718]: test: fix some unit test * ADM-747: [frontend] feat: handle error (#968) * ADM-747: [frontend] refactor: refactor notification * ADM-747: [frontend] refactor: set default title for notification * ADM-747: [frontend] feat: handle timeout error * ADM-747: [frontend] feat: handle report error * ADM-747: [frontend] refactor: rename reportMetricsError * ADM-747: [frontend] refactor: replace enum with object * ADM-747: [frontend] feat: handle report error * ADM-747: [frontend] feat: handle export error * ADM-747: [frontend] test: add tests for error notifications * ADM-747: [frontend] refactor: refactor report useEffect * ADM-747: [frontend] refactor: refactor TimeoutException * ADM-747: [frontend] refactor: delete useless isServerError * ADM-747: [frontend] test: add e2e tests for date picker * ADM-747: [frontend] fix: fix import * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: create new empty content component * [kai.zhou][adm-718]: test: fix some unit test * [kai.zhou][adm-718]: chroe: format code * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: create new empty content component * [kai.zhou][adm-718]: test: fix some unit test * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: test: fix some unit test * [kai.zhou][adm-718]: chroe: format code * [kai.zhou][adm-718]: fix failed unit test * [kai.zhou][adm-718]: add new stub for jira verify * [kai.zhou][adm-718]: fix failed unit test * [kai.zhou][adm-718]: add unit test for useVerifyBoardEffect * [kai.zhou][adm-718]: fix unit test coverage * [kai.zhou][adm-718]: update e2e test * [kai.zhou][adm-718]: update e2e stub * [kai.zhou][adm-718]: update stub data * ADM-718:[Frontend] Fix E2E stub data * ADM-718:[Frontend] Fix E2E stub data * ADM-718:[Frontend] Fix E2E stub data * [kai.zhou][adm-718]: fix email fields not post and ignore some e2e script * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: create new empty content component * [kai.zhou][adm-718]: test: fix some unit test * ADM-747: [frontend] feat: handle error (#968) * ADM-747: [frontend] refactor: refactor notification * ADM-747: [frontend] refactor: set default title for notification * ADM-747: [frontend] feat: handle timeout error * ADM-747: [frontend] feat: handle report error * ADM-747: [frontend] refactor: rename reportMetricsError * ADM-747: [frontend] refactor: replace enum with object * ADM-747: [frontend] feat: handle report error * ADM-747: [frontend] feat: handle export error * ADM-747: [frontend] test: add tests for error notifications * ADM-747: [frontend] refactor: refactor report useEffect * ADM-747: [frontend] refactor: refactor TimeoutException * ADM-747: [frontend] refactor: delete useless isServerError * ADM-747: [frontend] test: add e2e tests for date picker * ADM-747: [frontend] fix: fix import * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: test: fix some unit test * [kai.zhou][adm-718]: chroe: format code * [ADM-740] show not show real done when cycle time by status (#972) Co-authored-by: wenjing-qi <[email protected]> * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: create new empty content component * [kai.zhou][adm-718]: test: fix some unit test * [kai.zhou][adm-718]: refact board info call in metric page * [kai.zhou][adm-718]: test: fix some unit test * [kai.zhou][adm-718]: chroe: format code * [kai.zhou][adm-718]: fix failed unit test * [kai.zhou][adm-718]: fix unit test coverage * [kai.zhou][adm-718]: fix typo * [kai.zhou][adm-718]: fix local conflict * [kai.zhou][adm-718]: fix failed test * [kai.zhou][adm-718]: fix type * [kai.zhou][adm-718]: fix code for review * [kai.zhou][adm-718]: fix test typo * [kai.zhou][adm-718]: fix code styles * [kai.zhou][adm-718]: fix failed test * [kai.zhou][adm-718]: refact email token mix * [kai.zhou][adm-718]: add new test case * [kai.zhou][adm-718]: fix code styles * [kai.zhou][adm-718]: skip e2e test for creat project * [kai.zhou][adm-718]: fix pr issue * [kai.zhou][adm-718]: fix codacy issue * [kai.zhou][adm-718]: fix codacy issue * [kai.zhou][adm-718]: fix codacy issue * [kai.zhou][adm-718]: fix codacy issue * [kai.zhou][adm-718]: fix failed test * [kai.zhou][adm-718]: refact unit test * ADM-718:[Frontend] Fix Codacy issue * ADM-718:[Frontend] Fix rebase issue * ADM-718:[Frontend] Fix test case * [kai.zhou][adm-718]: fix not show form error * [kai.zhou][adm-718]: fix issues about deskcheck * ADM-718:[Frontend] Fix unit test case * [kai.zhou]: support reset error message when change form field * [kai.zhou][adm-718]: fix failed test * [kai.zhou][adm-718]: fix Classification can not update * [kai.zhou][adm-718]: refact unit test for classification * [kai.zhou][adm-718]: fix failed lint * [kai.zhou][adm-718]: fix lint warning * ADM-718:[Frontend] Remove some comments for E2E tests * [kai.zhou][adm-718]: fix form field warning --------- Co-authored-by: 姜如 <[email protected]> Co-authored-by: Simon Tal <[email protected]> Co-authored-by: gabralia <[email protected]> Co-authored-by: wenjing-qi <[email protected]>
Summary
Reference: https://dorametrics.atlassian.net/browse/ADM-740