enforce convergence condition

[najaverzat]

I changed the ColGenPhaseOutput structure to add a field min_sense (boolean). I use it to enforce the convergence condition in colgen_has_converged (I add the condition ( (output.min_sense) && (output.db >= output.mlp) ) || ( !(output.min_sense) && (output.db <= output.mlp) ) to the condition abs(output.mlp - output.db) < 1e-5

Remark: if I change the old condition abs(output.mlp - output.db) < 1e-5 by new condition ( (output.min_sense) && (output.db >= output.mlp) ) || ( !(output.min_sense) && (output.db <= output.mlp) ), test gap_with_all_phases_in_colgen failed (see log)

message.txt

[codecov]

Codecov Report

Patch coverage: 80.00% and no project coverage change.

Comparison is base (94e8757) 67.32% compared to head (68956cf) 67.32%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #861   +/-   ##
=======================================
  Coverage   67.32%   67.32%           
=======================================
  Files          78       78           
  Lines        6010     6010           
=======================================
  Hits         4046     4046           
  Misses       1964     1964           

Impacted Files	Coverage Δ
src/ColGen/interface.jl	71.96% <50.00%> (ø)
src/Algorithm/colgen/default.jl	98.54% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.