Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColGen: fix convergence condition #855

Closed
guimarqu opened this issue May 2, 2023 · 0 comments · Fixed by #861
Closed

ColGen: fix convergence condition #855

guimarqu opened this issue May 2, 2023 · 0 comments · Fixed by #861
Assignees

Comments

@guimarqu
Copy link
Contributor

guimarqu commented May 2, 2023

In some places, we check convergence as in the following method:

https://github.com/atoptima/Coluna.jl/blob/a2903a9803b44725797ef78defdc200c371259b7/src/Algorithm/colgen/default.jl#LL146C1-L146C136

This is not correct, because we should consider that the algorithm converged when the dual bound is equal or greater (resp lower) than the mlp in the minimization (resp maximization) case. Here, we only consider equality

@najaverzat najaverzat linked a pull request May 4, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants