Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node_finalizer in extra e2e tests #835

Merged
merged 3 commits into from
Apr 26, 2023
Merged

node_finalizer in extra e2e tests #835

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
664bbed
node_finalizer in extra e2e tests
guimarqu Apr 25, 2023
b36cf93
Merge branch 'master' into e2e_node_finalizer
guimarqu Apr 26, 2023
647bcad
Apply suggestions from code review
guimarqu Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/old/node_finalizer_tests.jl → ...a/advanced_colgen/node_finalizer_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ function ClA.run!(
return result
end


function test_node_finalizer(heuristic_finalizer)
function build_toy_model(optimizer)
toy = BlockModel(optimizer, direct_model = true)
Expand Down Expand Up @@ -62,7 +61,7 @@ function test_node_finalizer(heuristic_finalizer)
0, "Enumerative"
)
),
maxnumnodes = heuristic_finalizer ? 10000 : 1
maxnumnodes = heuristic_finalizer ? 15 : 1
)
)
)
Expand Down Expand Up @@ -158,7 +157,8 @@ function test_node_finalizer(heuristic_finalizer)
end
end

@testset "Old - node finalizer" begin
function test_node_finalizer()
test_node_finalizer(false) # exact
test_node_finalizer(true) # heuristic
end
end
register!(e2e_extra_tests, "node_finalizer", test_node_finalizer)