Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node_finalizer in extra e2e tests #835

Merged
merged 3 commits into from
Apr 26, 2023
Merged

node_finalizer in extra e2e tests #835

merged 3 commits into from
Apr 26, 2023

Conversation

guimarqu
Copy link
Contributor

Coluna fails this test.

Run ./revise.sh in Coluna folder to run only this test.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.18 ⚠️

Comparison is base (63acf4f) 62.81% compared to head (664bbed) 62.64%.

❗ Current head 664bbed differs from pull request most recent head b36cf93. Consider uploading reports for the commit b36cf93 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #835      +/-   ##
==========================================
- Coverage   62.81%   62.64%   -0.18%     
==========================================
  Files          76       73       -3     
  Lines        5758     5723      -35     
==========================================
- Hits         3617     3585      -32     
+ Misses       2141     2138       -3     

see 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

test/revise.jl Outdated Show resolved Hide resolved
test/e2e_extra/advanced_colgen/node_finalizer_tests.jl Outdated Show resolved Hide resolved
@guimarqu guimarqu marked this pull request as ready for review April 26, 2023 13:43
@guimarqu guimarqu merged commit 990b8c1 into master Apr 26, 2023
@guimarqu guimarqu deleted the e2e_node_finalizer branch May 10, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant