Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimap colours not updating on stylesheet modification #303

Closed
Siguza opened this issue Mar 27, 2015 · 5 comments
Closed

Minimap colours not updating on stylesheet modification #303

Siguza opened this issue Mar 27, 2015 · 5 comments

Comments

@Siguza
Copy link

Siguza commented Mar 27, 2015

The title says it all: If you change your (user-)stylesheet, the editor itself reloads all colours, the minimap doesn't.

Tested with

::shadow
{
    .source, .java.meta.class
    {
        color: #FFF;
    }
}
@fundon
Copy link
Member

fundon commented Mar 29, 2015

Thank you for your feedback.
We will check this.

@abe33
Copy link
Contributor

abe33 commented Mar 30, 2015

Nice catch, not sure if there's an event on user stylesheet reload, but if there is, we just have to hook on it.

@fundon
Copy link
Member

fundon commented Mar 30, 2015

https://atom.io/docs/api/v0.188.0/StyleManager
There is a StyleManager API and Atom has atom.styles object.

@fundon
Copy link
Member

fundon commented Mar 30, 2015

@abe33
Use of @subscriptions.add atom.styles.onDidAddStyleElement instead of @subscriptions.add atom.themes.onDidChangeActiveThemes (minimap-element.coffee) and it's working.

@subscriptions.add atom.styles.onDidAddStyleElement =>
      @invalidateCache()
      @requestForcedUpdate()

fundon added a commit that referenced this issue Mar 30, 2015
…les-reload

🐛 Fix not update when user-styles reload, #303
@fundon
Copy link
Member

fundon commented Mar 30, 2015

Landed in v4.7.0

@fundon fundon closed this as completed Mar 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants