🐛 Fix not update when user-styles reload, #303

atom-minimap · Mar 30, 2015 · af96175 · af96175 · abe33 · Mar 30, 2015
1 parent 94e02a9
commit af96175
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/lib/minimap-element.coffee b/lib/minimap-element.coffee
@@ -40,7 +40,12 @@ class MinimapElement extends HTMLElement
     @subscriptions = new CompositeDisposable
     @initializeContent()
 
-    @subscriptions.add atom.themes.onDidChangeActiveThemes =>
+    # Uses of `atom.styles.onDidAddStyleElement` instead of
+    # `atom.themes.onDidChangeActiveThemes`.
+    # Why?
+    # Currently, The styleElement will be removed first,
+    # and then re-add. So the `change` event has not be triggered.
+    @subscriptions.add atom.styles.onDidAddStyleElement =>
       @invalidateCache()
       @requestForcedUpdate()
 

diff --git a/spec/minimap-element-spec.coffee b/spec/minimap-element-spec.coffee
@@ -448,13 +448,15 @@ describe 'MinimapElement', ->
     #    ##    ## ##     ## ##   ### ##        ##  ##    ##
     #     ######   #######  ##    ## ##       ####  ######
 
-    describe 'when the atom themes are changed', ->
+    describe 'when the atom styles are changed', ->
       beforeEach ->
         nextAnimationFrame()
         spyOn(minimapElement, 'requestForcedUpdate').andCallThrough()
         spyOn(minimapElement, 'invalidateCache').andCallThrough()
 
-        atom.themes.emitter.emit 'did-change-active-themes'
+        styleNode = document.createElement('style')
+        styleNode.textContent = 'body{ color: #233; }'
+        atom.styles.emitter.emit 'did-add-style-element', styleNode
 
         waitsFor -> minimapElement.frameRequested