Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate/handle disallowed port in connection request #223

Merged
merged 23 commits into from
Sep 5, 2024
Merged

Investigate/handle disallowed port in connection request #223

merged 23 commits into from
Sep 5, 2024

Conversation

sajith
Copy link
Member

@sajith sajith commented Aug 30, 2024 •
edited
Loading

This should resolve #208. Changes:

  • Reject requests for invalid VLAN tags (the VLANs that are not configured on a port).
  • Reject requests for VLANs that are in use.
  • Handle requests for the special "any" value.
  • Add some tests.

Support for requests that contain ranges, "all", and "untagged" are to be implemented in a follow-up: see #224.

@sajith sajith linked an issue Aug 30, 2024 that may be closed by this pull request
Investigate behavior of reserve VLAN when the user requests an VLAN which is not allowed by OXP #208
Closed
@coveralls
Copy link

coveralls commented Aug 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10724236239

Details

  • 18 of 23 (78.26%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 88.658%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sdx_pce/topology/temanager.py 18 23 78.26%
Files with Coverage Reduction New Missed Lines %
src/sdx_pce/topology/temanager.py 7 88.37%
Totals Coverage Status
Change from base Build 10633690359: 0.02%
Covered Lines: 1125
Relevant Lines: 1247
💛 - Coveralls

sajith added 20 commits September 3, 2024 07:04
@sajith
Trim whitespace
d0f6e90
@sajith
Add some commentary
7e843f8
@sajith
Reformat comments
53af8ee
@sajith
Add a test to check for disallowed VLAN assignments
9eda84f
@sajith
Remove cruft
a35b98f
@sajith
Fix typo in log messages
1dc6f6e
@sajith
Log request type as "tm" or "not tm"
867e6df
@sajith
Fail if the requested VLAN tag is in use
6c2d20e
@sajith
Use ingress/egress user ports if available
23ede3a
@sajith
Do more logging when reserving a VLAN
620a980
@sajith
Log user ports
22248de
@sajith
Return VLAN allocations if we can't proceed
b4584b6
@sajith
Allocate a port when request is for "any" port
0afc9ce
@sajith
Check type before doing a dict.get()
3bfc032
@sajith
One unreserve_vlan() to rule them all
83bc209 
When an attempt to reserve VLANs for a request fails partially, we
should free all successful reservations and return an error.

#127 was the original
issue related to _unreserve_vlan() and _unreserve_vlan_breakdown().
It was less clear to me then how this should work.
@sajith
Add docstring
651d45b
@sajith
Update log messages
86fbe03
@sajith
Add docstring
e30e34a
@sajith
Make v2 request solvable
0d350d0
@sajith
Make the right assertions
8beda76
@sajith sajith marked this pull request as ready for review September 5, 2024 14:30
@sajith sajith mentioned this pull request Sep 5, 2024
Closed
@sajith sajith merged commit 4836ab7 into main Sep 5, 2024
11 checks passed
@sajith sajith deleted the 208.disallowed-vlans branch September 5, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YufengXin YufengXin YufengXin approved these changes

@italovalcy italovalcy Awaiting requested review from italovalcy

@congwang09 congwang09 Awaiting requested review from congwang09

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate behavior of reserve VLAN when the user requests an VLAN which is not allowed by OXP
3 participants
@sajith @coveralls @YufengXin