Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free/unreserve VLANs after use #127

Closed
sajith opened this issue Jun 28, 2023 · 0 comments · Fixed by #163
Closed

Free/unreserve VLANs after use #127

sajith opened this issue Jun 28, 2023 · 0 comments · Fixed by #163
Assignees
Labels

Comments

@sajith
Copy link
Member

sajith commented Jun 28, 2023

Grabbing an issue for these TODO items:

def _unreserve_vlan_breakdown(self, break_down):
# TODO: implement this
# with self._topology_lock:
# pass
assert False, "Not implemented"
def _unreserve_vlan(self, domain: str, port: dict, tag=None):
"""
Mark a VLAN tag as not in use.
"""
# with self._topology_lock:
# pass
assert False, "Not implemented"

Currently SDX Controller has not implemented DELETE /connection fully though, so that too will need to happen for this to be useful.

@sajith sajith added the enhancement New feature or request label Jun 28, 2023
@sajith sajith self-assigned this Jul 27, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in @sajith's project board Sep 12, 2023
sajith added a commit that referenced this issue Sep 5, 2024
When an attempt to reserve VLANs for a request fails partially, we
should free all successful reservations and return an error.

#127 was the original
issue related to _unreserve_vlan() and _unreserve_vlan_breakdown().
It was less clear to me then how this should work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

1 participant